feat: accept readonly array for multiple combobox value#9741
Open
lixiaoyan wants to merge 2 commits intoadobe:mainfrom
Open
feat: accept readonly array for multiple combobox value#9741lixiaoyan wants to merge 2 commits intoadobe:mainfrom
lixiaoyan wants to merge 2 commits intoadobe:mainfrom
Conversation
Port the readonly array changes from adobe#9221 (Select) to ComboBox. This allows passing `readonly Key[]` as the `value` prop for multiple selection mode without TypeScript errors. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
lixiaoyan
commented
Mar 5, 2026
| if (value !== undefined && props.inputValue !== undefined) { | ||
| props.onSelectionChange?.(selectedKey); | ||
| props.onChange?.(displayValue); | ||
| props.onChange?.(displayValue as ChangeValueType<M>); |
Contributor
Author
There was a problem hiding this comment.
I'm not sure if this is the right approach. Perhaps we could also update the change type to a readonly array at some point?
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ValueTypefor multiple selection mode now usesreadonly Key[]instead ofKey[], allowing users to pass readonly arrays as thevaluepropChangeValueType(mutableKey[]) for theonChangecallback, matching the Select patternconvertValuehelper to acceptreadonly Key[]Test plan
yarn check-typespasses with no new errorsComboBoxwithselectionMode="multiple"acceptsreadonly Key[]as value🤖 Generated with Claude Code