fix(ComboBox): avoid extra onSelectionChange calls#9729
Open
reidbarber wants to merge 1 commit intomainfrom
Open
fix(ComboBox): avoid extra onSelectionChange calls#9729reidbarber wants to merge 1 commit intomainfrom
reidbarber wants to merge 1 commit intomainfrom
Conversation
|
Build successful! 🎉 |
LFDanLu
reviewed
Mar 3, 2026
snowystinger
reviewed
Mar 3, 2026
| expect(preventDefault).toHaveBeenCalledTimes(1); | ||
| }); | ||
|
|
||
| it('should only call commit on Tab when the menu is open', function () { |
Member
There was a problem hiding this comment.
is this still true if it allows a custom value?
Member
There was a problem hiding this comment.
I think useComboBoxState will still clear the selected key on field blur via
still
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9727
Before:
onSelectionChangeonce (expected)After:
onSelectionChangecalls occur when values are already in sync✅ Pull Request Checklist:
📝 Test Instructions:
Unit tests should cover, but smoke test in storybook.
🧢 Your Project: