Skip to content

fix(localization): improve Finnish language (fi-Fi) screen reader localizations for combobox#8747

Closed
joonaojapalo wants to merge 1 commit into
adobe:mainfrom
joonaojapalo:intl-combobox-fi-FI-improvement
Closed

fix(localization): improve Finnish language (fi-Fi) screen reader localizations for combobox#8747
joonaojapalo wants to merge 1 commit into
adobe:mainfrom
joonaojapalo:intl-combobox-fi-FI-improvement

Conversation

@joonaojapalo

@joonaojapalo joonaojapalo commented Aug 20, 2025

Copy link
Copy Markdown

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue. Not applcable. I considered not worth opening an issue for tiny linguistic improvement.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests). Not applicable. Integrity of JSON already being tested by static imports and useLocalizedStringFormatter in useCombobox.
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component). Not applicable.
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Run storybook in related feature branch:

  1. Set browser language to Finnish
  2. Navigate to combobox's story with a screen reader
  3. Type into combobox's input a string which results multiple options available
  4. Verify that screen reader reads "X vaihtoehtoa saatavilla" (instead of current "X vaihtoehdot saatavilla")

@joonaojapalo joonaojapalo changed the title Improve Finnish language (fi-Fi) screen reader localizations for combobox chore(localization): improve Finnish language (fi-Fi) screen reader localizations for combobox Aug 21, 2025
@joonaojapalo joonaojapalo changed the title chore(localization): improve Finnish language (fi-Fi) screen reader localizations for combobox fix(localization): improve Finnish language (fi-Fi) screen reader localizations for combobox Aug 21, 2025
@joonaojapalo joonaojapalo force-pushed the intl-combobox-fi-FI-improvement branch from d8c8ec3 to 19e2adb Compare August 21, 2025 11:40
@snowystinger

Copy link
Copy Markdown
Member

Thanks for the PR, I opened a ticket with our translators for verification and alignment across Adobe. I'll update here when I learn more. Sometimes it can take a bit of time, but I haven't forgotten about your PR.

@rgeraghty

rgeraghty commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

I just managed to catch up on this one, thanks for reporting @joonaojapalo

We will merge in PR #8747 as translation needs to be updated in our backend DB and then we create PR - once merged I'll close this PR

@snowystinger

Copy link
Copy Markdown
Member

Closed by #10271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants