fix: remove invalid source package exports - #10495
Closed
HamedFarazi wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes invalid
sourceconditional exports from packages that excludetheir
exports/**source files from the published npm package.Affected packages:
react-ariareact-statelyreact-aria-components@adobe/react-spectrumWhen a bundler is configured with the
sourcecondition, these exportscan resolve to
./exports/*.tsfiles that are not included in thepublished package. Removing the invalid condition allows resolution to
fall back to the distributed
importentry.Changes
sourceexport from the root export.sourceexport from the wildcard export.🤖 AI Assistance
This PR was prepared with AI assistance. The changes were reviewed by me, and I understand the purpose and impact of
each change.
✅ Pull Request Checklist:
📝 Test Instructions:
Validation performed locally:
git diff --check— passed.package.jsonfiles — passed.The repository's runtime/type-checking tests were not run because the
local
node_modulesstate was not installed, soyarn check-typesandyarn test:ssrcould not be executed.Expected behavior:
yarn check-types.yarn test:ssr.sourcecondition resolveto their distributed
importentry instead of the missingexports/**/*.tsfiles.🧢 Your Project:
Personal open-source contribution.