fix: add DEFAULT_SLOT to TreeItem CheckboxContext so unslotted Checkboxes render#10274
Open
mvanhorn wants to merge 1 commit into
Open
fix: add DEFAULT_SLOT to TreeItem CheckboxContext so unslotted Checkboxes render#10274mvanhorn wants to merge 1 commit into
mvanhorn wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10204
✅ Pull Request Checklist:
📝 Test Instructions:
TreeItemprovided aCheckboxContext/CheckboxFieldContextwhoseslotsonly containedselection, unlikeTableRowandGridListItemwhich also include[DEFAULT_SLOT]: {}. As a result, anyCheckboxorCheckboxFieldwithoutslot="selection"rendered as a React descendant of aTreeItemthrewA slot prop is required. Valid slot names are "selection".This adds
[DEFAULT_SLOT]: {}to both slot maps inTreeItem, mirroringTable.tsx, so an unslotted checkbox renders normally while the existingslot="selection"behavior is unchanged.To verify:
Treewith aTreeItemcontaining an unslotted<Checkbox>in its content. It now renders without throwing.Checkbox slot="selection"inside aTreeItemstill drives selection (no regression).Tests:
Result: 109 passed, 1 skipped. Added a new case asserting an unslotted
Checkboxunder aTreeItemrenders without error.🧢 Your Project:
Community contribution.