Skip to content

chore: S2 LabeledValue follow-up#10061

Merged
yihuiliao merged 9 commits into
mainfrom
labeledvalue-followup
May 14, 2026
Merged

chore: S2 LabeledValue follow-up#10061
yihuiliao merged 9 commits into
mainfrom
labeledvalue-followup

Conversation

@yihuiliao
Copy link
Copy Markdown
Member

@yihuiliao yihuiliao commented May 13, 2026

  1. Remove labelAlign from the controls in the docs since it looked bad
  2. Adds an example of LabeledValue used in Form
  3. Adds LabeledValue to test apps
  4. Fixes segmented control in vite test app

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Go to LabeledValue docs and check to make sure labeledAlign has been removed. Also check new section under "Form". Check test apps to make sure LabeledValue has rendered correctly. Check vite test app to make sure segmented control looks correct.

🧢 Your Project:

@github-actions github-actions Bot added the S2 label May 13, 2026
@rspbot
Copy link
Copy Markdown

rspbot commented May 13, 2026

@rspbot
Copy link
Copy Markdown

rspbot commented May 13, 2026

@snowystinger
Copy link
Copy Markdown
Member

I was also supposed to add it to the test app but because LabeledValue isn't published yet it's a little difficult...so we just need to remember to add it after release

It should be published as a patch in verdaccio? What was happening?

Comment thread packages/dev/s2-docs/pages/s2/LabeledValue.mdx Outdated
@yihuiliao
Copy link
Copy Markdown
Member Author

I was also supposed to add it to the test app but because LabeledValue isn't published yet it's a little difficult...so we just need to remember to add it after release

It should be published as a patch in verdaccio? What was happening?

ah yes...i realized that when i woke up in the middle of the night...will fix

@rspbot
Copy link
Copy Markdown

rspbot commented May 13, 2026

@rspbot
Copy link
Copy Markdown

rspbot commented May 13, 2026

@rspbot
Copy link
Copy Markdown

rspbot commented May 13, 2026

Comment thread packages/dev/s2-docs/pages/s2/LabeledValue.mdx
@rspbot
Copy link
Copy Markdown

rspbot commented May 13, 2026

@yihuiliao yihuiliao added this pull request to the merge queue May 14, 2026
Merged via the queue into main with commit 6bcb47f May 14, 2026
29 checks passed
@yihuiliao yihuiliao deleted the labeledvalue-followup branch May 14, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants