fix: fix testing sheet workflow on github#10046
Merged
Merged
Conversation
|
Build successful! 🎉 |
reidbarber
previously approved these changes
May 11, 2026
snowystinger
approved these changes
May 11, 2026
Member
snowystinger
left a comment
There was a problem hiding this comment.
I guess my only concern is that if we have a bunch of translations, that could pretty quickly tip into the 100+ range as there are something like 32 locales
|
Build successful! 🎉 |
|
Build successful! 🎉 |
## API Changes
react-aria-components/react-aria-components:SliderFill-SliderFill {
- children?: ChildrenOrFunction<SliderFillRenderProps>
- className?: ClassNameOrFunction<SliderFillRenderProps> = 'react-aria-SliderFill'
- offset?: number = 0
- onHoverChange?: (boolean) => void
- onHoverEnd?: (HoverEvent) => void
- onHoverStart?: (HoverEvent) => void
- render?: DOMRenderFunction<keyof React.JSX.IntrinsicElements, SliderFillRenderProps>
- style?: StyleOrFunction<SliderFillRenderProps>
-}/react-aria-components:SliderFillContext-SliderFillContext {
- UNTYPED
-}/react-aria-components:SliderFillProps-SliderFillProps {
- children?: ChildrenOrFunction<SliderFillRenderProps>
- className?: ClassNameOrFunction<SliderFillRenderProps> = 'react-aria-SliderFill'
- offset?: number = 0
- onHoverChange?: (boolean) => void
- onHoverEnd?: (HoverEvent) => void
- onHoverStart?: (HoverEvent) => void
- render?: DOMRenderFunction<keyof React.JSX.IntrinsicElements, SliderFillRenderProps>
- style?: StyleOrFunction<SliderFillRenderProps>
-}/react-aria-components:SliderFillRenderProps-SliderFillRenderProps {
- isDisabled: boolean
- isHovered: boolean
- orientation: Orientation
- state: SliderState
-}/react-aria-components:ColorSliderState ColorSliderState {
decrementThumb: (number, number) => void
defaultValues: Array<number>
focusedThumb: number | undefined
getDisplayColor: () => Color
- getFormattedValue: (number | Array<number>) => string
+ getFormattedValue: (number) => string
getPercentValue: (number) => number
getThumbMaxValue: (number) => number
getThumbMinValue: (number) => number
getThumbPercent: (number) => number
getThumbValueLabel: (number) => string
getValuePercent: (number) => number
incrementThumb: (number, number) => void
isDisabled: boolean
isDragging: boolean
isThumbDragging: (number) => boolean
isThumbEditable: (number) => boolean
orientation: Orientation
pageSize: number
setFocusedThumb: (number | undefined) => void
setThumbDragging: (number, boolean) => void
setThumbEditable: (number, boolean) => void
setThumbPercent: (number, number) => void
setThumbValue: (number, number) => void
setValue: (string | Color) => void
step: number
value: Color
values: Array<number>
}/react-aria-components:SliderState SliderState {
decrementThumb: (number, number) => void
defaultValues: Array<number>
focusedThumb: number | undefined
- getFormattedValue: (number | Array<number>) => string
+ getFormattedValue: (number) => string
getPercentValue: (number) => number
getThumbMaxValue: (number) => number
getThumbMinValue: (number) => number
getThumbPercent: (number) => number
getThumbValueLabel: (number) => string
getValuePercent: (number) => number
incrementThumb: (number, number) => void
isDisabled: boolean
isThumbDragging: (number) => boolean
isThumbEditable: (number) => boolean
orientation: Orientation
pageSize: number
setFocusedThumb: (number | undefined) => void
setThumbDragging: (number, boolean) => void
setThumbEditable: (number, boolean) => void
setThumbPercent: (number, number) => void
setThumbValue: (number, number) => void
step: number
values: Array<number>
}@react-stately/color/@react-stately/color:ColorSliderState ColorSliderState {
decrementThumb: (number, number) => void
defaultValues: Array<number>
focusedThumb: number | undefined
getDisplayColor: () => Color
- getFormattedValue: (number | Array<number>) => string
+ getFormattedValue: (number) => string
getPercentValue: (number) => number
getThumbMaxValue: (number) => number
getThumbMinValue: (number) => number
getThumbPercent: (number) => number
getThumbValueLabel: (number) => string
getValuePercent: (number) => number
incrementThumb: (number, number) => void
isDisabled: boolean
isDragging: boolean
isThumbDragging: (number) => boolean
isThumbEditable: (number) => boolean
orientation: Orientation
pageSize: number
setFocusedThumb: (number | undefined) => void
setThumbDragging: (number, boolean) => void
setThumbEditable: (number, boolean) => void
setThumbPercent: (number, number) => void
setThumbValue: (number, number) => void
setValue: (string | Color) => void
step: number
value: Color
values: Array<number>
}@react-stately/slider/@react-stately/slider:SliderState SliderState {
decrementThumb: (number, number) => void
defaultValues: Array<number>
focusedThumb: number | undefined
- getFormattedValue: (number | Array<number>) => string
+ getFormattedValue: (number) => string
getPercentValue: (number) => number
getThumbMaxValue: (number) => number
getThumbMinValue: (number) => number
getThumbPercent: (number) => number
getThumbValueLabel: (number) => string
getValuePercent: (number) => number
incrementThumb: (number, number) => void
isDisabled: boolean
isThumbDragging: (number) => boolean
isThumbEditable: (number) => boolean
orientation: Orientation
pageSize: number
setFocusedThumb: (number | undefined) => void
setThumbDragging: (number, boolean) => void
setThumbEditable: (number, boolean) => void
setThumbPercent: (number, number) => void
setThumbValue: (number, number) => void
step: number
values: Array<number>
} |
devongovett
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i was using npm when i should have been using yarn 😅
but otherwise fixes the test off PR label (bc it needs to look at the PR's that are currently open, not the commits on main) and adds LabeledValue to the list of valid labels
also skips labeling if the number of files changed exceed 100s. this is an arbitrary number, happy to lower it if we feel like that might make more sense. see docs: https://github.com/actions/labeler#skipping-labeling-for-large-prs
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: