Skip to content

fix: fix testing sheet workflow on github#10046

Merged
yihuiliao merged 5 commits into
mainfrom
fix-testing-sheet
May 12, 2026
Merged

fix: fix testing sheet workflow on github#10046
yihuiliao merged 5 commits into
mainfrom
fix-testing-sheet

Conversation

@yihuiliao
Copy link
Copy Markdown
Member

@yihuiliao yihuiliao commented May 11, 2026

i was using npm when i should have been using yarn 😅

but otherwise fixes the test off PR label (bc it needs to look at the PR's that are currently open, not the commits on main) and adds LabeledValue to the list of valid labels

also skips labeling if the number of files changed exceed 100s. this is an arbitrary number, happy to lower it if we feel like that might make more sense. see docs: https://github.com/actions/labeler#skipping-labeling-for-large-prs

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link
Copy Markdown

rspbot commented May 11, 2026

reidbarber
reidbarber previously approved these changes May 11, 2026
Copy link
Copy Markdown
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess my only concern is that if we have a bunch of translations, that could pretty quickly tip into the 100+ range as there are something like 32 locales

@rspbot
Copy link
Copy Markdown

rspbot commented May 11, 2026

@rspbot
Copy link
Copy Markdown

rspbot commented May 11, 2026

@rspbot
Copy link
Copy Markdown

rspbot commented May 11, 2026

## API Changes

react-aria-components

/react-aria-components:SliderFill

-SliderFill {
-  children?: ChildrenOrFunction<SliderFillRenderProps>
-  className?: ClassNameOrFunction<SliderFillRenderProps> = 'react-aria-SliderFill'
-  offset?: number = 0
-  onHoverChange?: (boolean) => void
-  onHoverEnd?: (HoverEvent) => void
-  onHoverStart?: (HoverEvent) => void
-  render?: DOMRenderFunction<keyof React.JSX.IntrinsicElements, SliderFillRenderProps>
-  style?: StyleOrFunction<SliderFillRenderProps>
-}

/react-aria-components:SliderFillContext

-SliderFillContext {
-  UNTYPED
-}

/react-aria-components:SliderFillProps

-SliderFillProps {
-  children?: ChildrenOrFunction<SliderFillRenderProps>
-  className?: ClassNameOrFunction<SliderFillRenderProps> = 'react-aria-SliderFill'
-  offset?: number = 0
-  onHoverChange?: (boolean) => void
-  onHoverEnd?: (HoverEvent) => void
-  onHoverStart?: (HoverEvent) => void
-  render?: DOMRenderFunction<keyof React.JSX.IntrinsicElements, SliderFillRenderProps>
-  style?: StyleOrFunction<SliderFillRenderProps>
-}

/react-aria-components:SliderFillRenderProps

-SliderFillRenderProps {
-  isDisabled: boolean
-  isHovered: boolean
-  orientation: Orientation
-  state: SliderState
-}

/react-aria-components:ColorSliderState

 ColorSliderState {
   decrementThumb: (number, number) => void
   defaultValues: Array<number>
   focusedThumb: number | undefined
   getDisplayColor: () => Color
-  getFormattedValue: (number | Array<number>) => string
+  getFormattedValue: (number) => string
   getPercentValue: (number) => number
   getThumbMaxValue: (number) => number
   getThumbMinValue: (number) => number
   getThumbPercent: (number) => number
   getThumbValueLabel: (number) => string
   getValuePercent: (number) => number
   incrementThumb: (number, number) => void
   isDisabled: boolean
   isDragging: boolean
   isThumbDragging: (number) => boolean
   isThumbEditable: (number) => boolean
   orientation: Orientation
   pageSize: number
   setFocusedThumb: (number | undefined) => void
   setThumbDragging: (number, boolean) => void
   setThumbEditable: (number, boolean) => void
   setThumbPercent: (number, number) => void
   setThumbValue: (number, number) => void
   setValue: (string | Color) => void
   step: number
   value: Color
   values: Array<number>
 }

/react-aria-components:SliderState

 SliderState {
   decrementThumb: (number, number) => void
   defaultValues: Array<number>
   focusedThumb: number | undefined
-  getFormattedValue: (number | Array<number>) => string
+  getFormattedValue: (number) => string
   getPercentValue: (number) => number
   getThumbMaxValue: (number) => number
   getThumbMinValue: (number) => number
   getThumbPercent: (number) => number
   getThumbValueLabel: (number) => string
   getValuePercent: (number) => number
   incrementThumb: (number, number) => void
   isDisabled: boolean
   isThumbDragging: (number) => boolean
   isThumbEditable: (number) => boolean
   orientation: Orientation
   pageSize: number
   setFocusedThumb: (number | undefined) => void
   setThumbDragging: (number, boolean) => void
   setThumbEditable: (number, boolean) => void
   setThumbPercent: (number, number) => void
   setThumbValue: (number, number) => void
   step: number
   values: Array<number>
 }

@react-stately/color

/@react-stately/color:ColorSliderState

 ColorSliderState {
   decrementThumb: (number, number) => void
   defaultValues: Array<number>
   focusedThumb: number | undefined
   getDisplayColor: () => Color
-  getFormattedValue: (number | Array<number>) => string
+  getFormattedValue: (number) => string
   getPercentValue: (number) => number
   getThumbMaxValue: (number) => number
   getThumbMinValue: (number) => number
   getThumbPercent: (number) => number
   getThumbValueLabel: (number) => string
   getValuePercent: (number) => number
   incrementThumb: (number, number) => void
   isDisabled: boolean
   isDragging: boolean
   isThumbDragging: (number) => boolean
   isThumbEditable: (number) => boolean
   orientation: Orientation
   pageSize: number
   setFocusedThumb: (number | undefined) => void
   setThumbDragging: (number, boolean) => void
   setThumbEditable: (number, boolean) => void
   setThumbPercent: (number, number) => void
   setThumbValue: (number, number) => void
   setValue: (string | Color) => void
   step: number
   value: Color
   values: Array<number>
 }

@react-stately/slider

/@react-stately/slider:SliderState

 SliderState {
   decrementThumb: (number, number) => void
   defaultValues: Array<number>
   focusedThumb: number | undefined
-  getFormattedValue: (number | Array<number>) => string
+  getFormattedValue: (number) => string
   getPercentValue: (number) => number
   getThumbMaxValue: (number) => number
   getThumbMinValue: (number) => number
   getThumbPercent: (number) => number
   getThumbValueLabel: (number) => string
   getValuePercent: (number) => number
   incrementThumb: (number, number) => void
   isDisabled: boolean
   isThumbDragging: (number) => boolean
   isThumbEditable: (number) => boolean
   orientation: Orientation
   pageSize: number
   setFocusedThumb: (number | undefined) => void
   setThumbDragging: (number, boolean) => void
   setThumbEditable: (number, boolean) => void
   setThumbPercent: (number, number) => void
   setThumbValue: (number, number) => void
   step: number
   values: Array<number>
 }

@yihuiliao yihuiliao added this pull request to the merge queue May 12, 2026
Merged via the queue into main with commit f6f4206 May 12, 2026
31 checks passed
@yihuiliao yihuiliao deleted the fix-testing-sheet branch May 12, 2026 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants