Skip to content

fix: avoid forwarding overlay props in Tailwind starter Modal #10027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tobiase wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −2
Draft

fix: avoid forwarding overlay props in Tailwind starter Modal #10027

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions starters/tailwind/src/Modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,26 @@ const modalStyles = tv({
}
});

export function Modal(props: ModalOverlayProps) {
Copy link
Copy Markdown
Member

@snowystinger snowystinger May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given that the type specified here is ModalOverlayProps, I think we can just stop passing the props to the RACModal?

export function Modal({children, ...props}: ModalOverlayProps) {
let {
isDismissable,
isKeyboardDismissDisabled,
isOpen,
defaultOpen,
onOpenChange,
isEntering,
isExiting,
UNSTABLE_portalContainer,
shouldCloseOnInteractOutside,
...modalProps
} = props;

return (
<ModalOverlay {...props} className={overlayStyles}>
<div className="sticky top-0 left-0 w-full h-(--visual-viewport-height) flex items-center justify-center box-border">
<RACModal {...props} className={modalStyles} />
<RACModal {...modalProps} className={modalStyles}>
Comment on lines -34 to +47
Copy link
Copy Markdown
Member

@snowystinger snowystinger May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or does this cause some issue I'm not thinking of?
<RACModal className={modalStyles}>

{children}
</RACModal>
</div>
</ModalOverlay>
);
Expand Down
Loading