Skip to content

fix(select): Select component keyboard type-ahead#10006

Open
withlakshmanan wants to merge 6 commits intoadobe:mainfrom
withlakshmanan:fix/select-type-a-head-issue
Open

fix(select): Select component keyboard type-ahead#10006
withlakshmanan wants to merge 6 commits intoadobe:mainfrom
withlakshmanan:fix/select-type-a-head-issue

Conversation

@withlakshmanan
Copy link
Copy Markdown

@withlakshmanan withlakshmanan commented May 2, 2026

Description
The fix makes Select keyboard typeahead behave correctly for repeated letters and ensures search continues from the next option rather than reusing the current focused item.

Screen recording

Screen.Recording.2026-04-25.at.1.58.40.PM.mov

Issue link
#8919

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@github-actions github-actions Bot added the RAC label May 2, 2026
@snowystinger
Copy link
Copy Markdown
Member

Looks like it's still failing tests, how would you like to handle those? Do you need assistance? Also, it looks like you haven't signed the CLA, see https://github.com/adobe/react-spectrum/blob/main/CONTRIBUTING.md#contributor-license-agreement

@withlakshmanan
Copy link
Copy Markdown
Author

@snowystinger I already signed though the email notification. but still not passing. I need your help on that.

@snowystinger
Copy link
Copy Markdown
Member

I've updated with a merge from main, hopefully that fixes the remaining two test failures that I don't think were your fault.

As for the CLA, could you try again and double check the e-mail used. This happens pretty frequently, especially when people have multiple accounts/emails/etc. It doesn't look like the service is down as other PRs are being successfully checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants