Fix e2e failures Fix test failures#91
Merged
sandeep-paliwal merged 5 commits intomasterfrom Jan 27, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #91 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 533 543 +10
Branches 15 15
=========================================
+ Hits 533 543 +10 ☔ View full report in Codecov by Sentry. |
moritzraho
approved these changes
Dec 6, 2024
shazron
approved these changes
Dec 6, 2024
Member
shazron
left a comment
There was a problem hiding this comment.
that issue you mentioned might be related to this? adobe/aio-cli-lib-console#85
…to create credential. As as workaround calling the API directly using axios.
Fix test code
… dependent tests as there is problem with jest and API call ends up getting timedout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed all test failures. There are one set of tests still failing for credential related tests because of following issue . Once the issue is fixed remaining tests should run fine.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Manual e2e run
Screenshots (if appropriate):
Types of changes
Checklist: