Skip to content

restore process.env after exec action with side-effects #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
purplecabbage merged 5 commits into from
Jun 4, 2025
Merged

restore process.env after exec action with side-effects #153

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
15249ff
restore process.env after exec action with side-effects
purplecabbage May 30, 2025
595f2b5
added try/catch/finally to ensure env gets reset even if the action t…
purplecabbage Jun 2, 2025
66695b9
Use Object.assign since env props are only strings
purplecabbage Jun 3, 2025
53ba902
remove outdated comment
purplecabbage Jun 3, 2025
4d6bd5e
spread syntax for cloning
purplecabbage Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/lib/run-dev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,6 +349,11 @@ async function invokeAction ({ actionRequestContext, logger }) {
}
}
}

// if we run an action, we will restore the process.env after the call
// we must do this before we load the action because code can execute on require/import
const preCallEnv = Object.assign({}, process.env)
Comment thread
purplecabbage marked this conversation as resolved.
Outdated
const originalCwd = process.cwd()
// generate an activationID just like openwhisk
process.env.__OW_ACTIVATION_ID = crypto.randomBytes(16).toString('hex')
Comment thread
purplecabbage marked this conversation as resolved.

Expand Down Expand Up @@ -417,6 +422,10 @@ async function invokeAction ({ actionRequestContext, logger }) {
statusCode,
body: { error: 'Response is not valid \'message/http\'.' }
}
} finally {
logger.debug('restoring process.env and cwd')
process.env = preCallEnv // restore the environment variables
Copy link

Copilot AI Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reassigning process.env can break references elsewhere; instead clear the existing process.env and reassign properties, e.g. delete all keys then Object.assign(process.env, preCallEnv), to preserve the env object identity.

Copilot uses AI. Check for mistakes.
process.chdir(originalCwd) // restore the original working directory
}
} else {
// this case the action returned an error object, so we should use it
Expand Down