Skip to content

fix(AdiveryModule): Handle promise rejection for ad load/show failures #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mootzali wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(AdiveryModule): Handle promise rejection for ad load/show failures #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions android/src/main/java/com/adivery/AdiveryModule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,11 +224,16 @@ class AdiveryModule(private val reactContext: ReactApplicationContext) :
}

override fun onAdLoadFailed(reason: String) {
promise.reject(reason)
promise.reject("AD_LOAD_FAILED", reason)
}

override fun onAdShowFailed(reason: String) {
promise.reject(reason)
// The promise is already resolved in onAdLoaded; rejecting it here is dropped by RN.
// Surface show-failures via the global error event instead.
val params = Arguments.createMap()
params.putString("placementId", placementId)
params.putString("message", reason)
sendEvent(reactContext, ON_ERROR_EVENT_NAME, params)
}
})
}
Expand Down