forked from codex-team/editor.js
-
Notifications
You must be signed in to change notification settings - Fork 3
improve block insert method #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Wanxin-Hu
wants to merge
11
commits into
next
Choose a base branch
from
wanxin-issue1817
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
95fb814
Changed insert method argument, signature, and where it's called.
zang77 9bb0190
Changed insert method argument, signature, and where it's called.
zang77 2df3e1e
edit documentation, create a type for blocks
Wanxin-Hu babaf35
improved insert method
Wanxin-Hu 07269ab
Merge pull request #2 from Wanxin-Hu/next
Wanxin-Hu 10ba7e3
Merge pull request #3 from aditink/wanxin-issue1817
Wanxin-Hu 765b03f
Revert "Wanxin issue1817, fixed insert method."
Wanxin-Hu d82a937
Merge pull request #4 from aditink/revert-3-wanxin-issue1817
Wanxin-Hu 3e8527c
improve block insert method
Wanxin-Hu 347e7c1
fixed formatting problem
Wanxin-Hu c56e80c
some minor fix
Wanxin-Hu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| import { InsertedBlock } from '.'; | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Space around InseredBlock contrary to the formatting used in this file. |
||
| import {OutputData} from '../data-formats/output-data'; | ||
| import {BlockToolData, ToolConfig} from '../tools'; | ||
| import {BlockAPI} from './block'; | ||
|
|
@@ -96,21 +97,9 @@ export interface Blocks { | |
| /** | ||
| * Insert new Block and return inserted Block API | ||
| * | ||
| * @param {string} type — Tool name | ||
| * @param {BlockToolData} data — Tool data to insert | ||
| * @param {ToolConfig} config — Tool config | ||
| * @param {number?} index — index where to insert new Block | ||
| * @param {boolean?} needToFocus - flag to focus inserted Block | ||
| * @param {boolean?} replace - should the existed Block on that index be replaced or not | ||
| */ | ||
| insert( | ||
| type?: string, | ||
| data?: BlockToolData, | ||
| config?: ToolConfig, | ||
| index?: number, | ||
| needToFocus?: boolean, | ||
| replace?: boolean, | ||
| ): BlockAPI; | ||
| * @param {InsertedBlock} block - new block config | ||
| */ | ||
| insert(block: InsertedBlock): BlockAPI; | ||
|
|
||
|
|
||
| /** | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Space in
insert (blockcontrary to pattern used in the rest of the file.