feat(compliance): add DOOH sales profile - #6619
Conversation
There was a problem hiding this comment.
Ladon verdict: Escalate to human review
Escalate — gated-path change requires human/CODEOWNERS approval.
This PR modifies protocol source files under static/schemas/source/** (comply-test-controller-request.json, comply-test-controller-response.json, enums/specialism.json), which are under the repo's hard, path-based approval gate (gated_paths: true). The current review_decision is REVIEW_REQUIRED, not APPROVED, so per decision rule row 2 the gate is not satisfied and the outcome must be escalate.
The reviewer found no blocking or medium findings: the change is purely additive (new sales-dooh specialism plus plays/dooh_metrics delivery-simulation support and an MCP content[].text de-duplication). Enum, docs, OpenAPI registry, taxonomy, and SPECIALISM_CATALOG are coherent; the minor changeset matches the additive, no-wire-removal surface; dooh_metrics uses allOf+$ref rather than a new undiscriminated oneOf; and the load-bearing single-package delivery checks are covered, including a new multi-package rejection test. The diff appears clean on the merits.
No critical/high/medium findings were surfaced, so this is not request-changes. But the gated-path approval gate stands until a human/CODEOWNERS approval flips review_decision to APPROVED.
Escalation reasons:
- Modifies gated protocol-source files under
static/schemas/source/**— human/CODEOWNERS review required before merge (review_decision is REVIEW_REQUIRED, not APPROVED).
Why human review
- Modifies gated files under static/schemas/source/** (comply-test-controller-request.json, comply-test-controller-response.json, enums/specialism.json) with review_decision=REVIEW_REQUIRED — human/CODEOWNERS approval required (decision rule row 2).
- This PR touches a path under a hard, non-overridable approval gate (static/schemas/source/compliance/comply-test-controller-request.json (modified) matches
static/schemas/source/**; static/schemas/source/compliance/comply-test-controller-response.json (modified) matchesstatic/schemas/source/**; static/schemas/source/enums/specialism.json (modified) matchesstatic/schemas/source/**) and the current GitHub review decision is 'REVIEW_REQUIRED', not APPROVED. This is a hard gate enforced in code — Ladon cannot auto-approve until a human/CODEOWNERS approval is recorded, regardless of how clean the diff is.
Summary
sales-doohspecialism for non-guaranteed DOOH, using existing Product, placement, canonical-format,plays, anddooh_metricscontracts rather than a new Product subtypestructuredContent, and align reference producers so payloads are not duplicatedsandbox: true; account IDs select preverified sandbox accounts and cannot convert live accountsReview focus
sales-doohcorrectly scoped as the non-guaranteed channel profile, with guaranteed-only DOOH continuing to usesales-guaranteed?tools/listpages?Validation