Skip to content

test: add comprehensive creative protocol testing #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
prateakb wants to merge 3 commits into from
Closed

test: add comprehensive creative protocol testing #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2652fe2
test: add comprehensive creative protocol testing with testCreativeLi…
prateakb Mar 17, 2026
b225d77
chore: update package-lock.json
prateakb Mar 17, 2026
bef70f2
style: format creative testing files with Prettier
prateakb Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .changeset/creative-protocol-testing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
---
'@adcp/client': minor
---

Add comprehensive creative protocol testing with testCreativeLifecycle scenario

- Implements full creative workflow testing: list_formats → sync_creatives (multi) → list_creatives (with/without snapshot) → build_creative
- Adds snapshot field validation with coverage for as_of, staleness_seconds, impressions, last_served fields
- Validates snapshot_unavailable_reason enum (SNAPSHOT_UNSUPPORTED, SNAPSHOT_TEMPORARILY_UNAVAILABLE, SNAPSHOT_PERMISSION_DENIED)
- Tests both generative mode (brand_manifest + prompt) and tag-serving mode (creative_id) for build_creative
- Extends schema-compliance.ts with creative response schema validation for list_creatives and sync_creatives
- Validates creative_id, format_id, action status, and error handling in sync responses
- Resolves issues #328, #329, #330 by ensuring creative tools are properly tested independently and schema validation is comprehensive
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading