Skip to content

feat: bump ADCP spec to 3.0.0-rc.3#164

Closed
EmmaLouise2018 wants to merge 1 commit intomainfrom
EmmaLouise2018/check-adcp-rc-ver
Closed

feat: bump ADCP spec to 3.0.0-rc.3#164
EmmaLouise2018 wants to merge 1 commit intomainfrom
EmmaLouise2018/check-adcp-rc-ver

Conversation

@EmmaLouise2018
Copy link
Copy Markdown
Contributor

Summary

  • Bumps ADCP spec from 3.0.0-rc.2 to 3.0.0-rc.3
  • Syncs 329 schemas (+16 new) and regenerates all Pydantic types (1022 exports)
  • Handles breaking changes: GetProductsRequest consolidation (3 variants → 1), FormatCategory inlining, type field removal from media-buy ListCreativeFormatsRequest
  • Fixes codegen pipeline: sort priority for core/ types, ergonomic coercion imports for BuyingMode/ValidAction

New rc.3 schema areas

  • Compliance testing (compliance/)
  • Trusted Match Protocol (tmp/)
  • Insertion orders, deadlines, installments (core/insertion-order, core/deadline-policy, etc.)
  • Collections (replaces shows)
  • Placement definitions (core/placement-definition)

Test plan

  • ruff check src/ passes
  • import adcp succeeds
  • CI lint/mypy/test pipeline
  • Verify backward compat for FormatCategory and GetProductsBriefRequest/GetProductsWholesaleRequest/GetProductsRefineRequest aliases

Known issues

  • ListCreativeFormatsRequest.type field removed from media-buy version in rc.3 (moved to creative-agent only) — tests referencing this field will need updating in a follow-up

- Sync 329 schemas (+16 new) from adcontextprotocol.org
- Regenerate Pydantic types from rc.3 schemas (1022 exports)
- Handle GetProductsRequest consolidation (3 variants → 1 unified class)
- Add FormatCategory backward-compat alias (inlined as Type in rc.3)
- Fix consolidate_exports sort priority (core/ before compliance/)
- Fix ergonomic coercion generator for BuyingMode/ValidAction imports

New rc.3 schema areas: compliance testing, trusted-match (TMP),
insertion-orders, deadline-policy, placement-definition, collections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant