Open
Conversation
Add an option to useParentHeight as the target height of the container. If you have a fixed height parent with more then 1 column the math (targetHeight = maxHeight / numCols) breaks down
Owner
|
the goal here would be to fill the parent's height entirely, but not necessarily its width? for instance, if you had enough text to fill 50% of the parent container, then it would fill the left side with columnized content instead of the top half as it currently does, yes? just making sure i'm understanding your use case. any reason you can't just pass in the height option explicitly? |
Author
|
yes exactly. I could pass the height explicitly, but that also limited the number of loops which caused some odd display issues in my case. |
|
@djgilcrease: Is it possible to do this with current columnizer code? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an option to useParentHeight as the target height of the container.
If you have a fixed height parent with more then 1 column the math (targetHeight = maxHeight / numCols) breaks down