chore: satisfy linting concerns from ruff#145
Conversation
2bndy5
left a comment
There was a problem hiding this comment.
About check=True concern.
tekktrik
left a comment
There was a problem hiding this comment.
Some minor changes but all of these look good. We could push the line length out but I think this is still fine and readable for now.
|
I think the typing concerns would be better addressed using mypy. But the pre-commit config (proposed in #144) does not currently include mypy usage. Would you like another PR to add mypy into the CI (and fix any any typing problems that arise)? |
|
I would separate |
FYI, I spent almost 20 minutes trying to track down the types of the parameters you questioned. Using mypy can avoid wasting that much time. A quick run of mypy shows that most problems originate from not having type stubs for dependencies. If that result remains persistent, then it would be beneficial for maintainers alone. |
- a step toward resolving adafruit#138
|
It turns out that the typing here is much more of a mess than I thought. Honestly addressing the typing errors/warnings would feel like a total rewrite, and, at that point, I would just use rust with a python binding. |
Uh oh!
There was an error while loading. Please reload this page.