feat: add Seeed XIAO nRF52840 BLE/Sense boards with SoftDevice S340#360
feat: add Seeed XIAO nRF52840 BLE/Sense boards with SoftDevice S340#360JuergenLeber wants to merge 1 commit intoadafruit:masterfrom
Conversation
hathach
left a comment
hathach
left a comment
There was a problem hiding this comment.
you may want to include the ci _s340 filter here as part of the PR as well. Though I am still thinking whether we should include these board with s340 since it is not buildable (therefore not maintainable in the future). Since s340 is only local buildable, and need local changes, maybe it makes sense to let user change the board.mk from s140 --> s340 themself.
|
You're right @hathach - every board with S340 would just be a copy of a S140 one with some name changes. What do you think about a small script that would do the job locally? (copy board, make changes in naming, etc) |
|
I think the only changes is needed is SD_NAME and SD_VERSION, we can change = in board.mk/cmake with ?= (ifndef) to allow passing it with make/cmake command line and that should be good enough ? |
|
Sounds good @hathach! So it can be easily built with every board. Do you want to change it or should I change this PR? |
|
@hathach I'll take care of it and will change this PR as discussed! |
|
As discussed this one will be closed. |
2 participants
Checklist
By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes
UF2_BOARD_IDin your board.h follow correct format from uf2 specsDescription of Change
This PR needs #359 as a prerequisite and extends the two existing Seeed XIAO nRF52840 BLE and Sense boards with SoftDevice S340 functionality. The automatic build workflow for these two new boards will fail until #359 has been pulled as the closed source files are not included and S340 builds are then excluded. The build only works locally after following the instructions in the README.md to add the necessary closed source files. It doesn't break anything else.