Conversation
| bits = bits << 1 | ||
| else: | ||
| bits += 8 | ||
| self._bits_per_value = bits |
There was a problem hiding this comment.
This mimics the logic from blinka displayio here: https://github.com/adafruit/Adafruit_Blinka_Displayio/blob/01b274d3a058b8efb7b3c3638511724cbc290a7d/displayio/_bitmap.py#L64-L68
It may ultimately be worth spending a little time to try to update these tests to utilize Blinka Displayio instead of these one-off mocked implementations of core classes anywhere possible.
There was a problem hiding this comment.
Note that the tests failing was unrelated to the primary change in this PR. I believe the root cause of that is bitmaptools being added to Blinka Displayio since the last time these tests were run. The code for this test takes a path that involves using both these mocked Interface class, and the new implementations of bitmaptools which exposed that the Interface was missing this internal field that readinto is relying on.
Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SSD1306 to 3.0.2 from 3.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SSD1306#52 from FoamyGuy/displayio_api_updates Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1322 to 1.4.6 from 1.4.5: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1322#26 from FoamyGuy/update_fourwire_refs Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1608 to 1.3.5 from 1.3.4: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1608#19 from FoamyGuy/displayio_api_updates Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 3.3.2 from 3.3.1: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#224 from FoamyGuy/displayio_api_updates Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout to 3.0.1 from 3.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#101 from FoamyGuy/displayio_api_update Updating https://github.com/adafruit/Adafruit_CircuitPython_Gizmo to 1.3.22 from 1.3.21: > Merge pull request adafruit/Adafruit_CircuitPython_Gizmo#29 from FoamyGuy/displayio_api_updates Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 1.24.3 from 1.24.2: > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#101 from FoamyGuy/displayio_api_updates
2 participants
No description provided.