Added docker.md, dockerfile and docker-compose.yaml#15
Open
Adesoji1 wants to merge 2 commits intoactualize-ae:mainfrom
Open
Added docker.md, dockerfile and docker-compose.yaml#15Adesoji1 wants to merge 2 commits intoactualize-ae:mainfrom
Adesoji1 wants to merge 2 commits intoactualize-ae:mainfrom
Conversation
|
@Adesoji1 Thanks for the efforts, let me review it and update here 👍 |
Mohit21GoJs
reviewed
Jan 19, 2025
Mohit21GoJs
reviewed
Jan 19, 2025
Author
|
i used both node 18 and node 22 and it worked well, i will share the
screenshots tomorrow, i only wanted to try a recent node version and that
was why i tried 22.
…On Sun, 19 Jan 2025 at 10:40, Mohit Yadav ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In Dockerfile
<#15 (comment)>
:
> @@ -0,0 +1,52 @@
+# Use the official Node.js 22 LTS image as the base image
+FROM node:22-alpine AS base
@Adesoji1 <https://github.com/Adesoji1> Any specific reason for using
simple node:22 image here?
When i run command
docker build --no-cache -t my-nextjs-app .
With node:22-alpine - i get this error
79.92 npm error code ETIMEDOUT
79.92 npm error errno ETIMEDOUT
79.92 npm error network request to https://registry.npmjs.org/pnpm failed, reason:
79.92 npm error network This is a problem related to network connectivity.
79.92 npm error network In most cases you are behind a proxy or have bad network settings.
79.92 npm error network
79.92 npm error network If you are behind a proxy, please make sure that the
79.92 npm error network 'proxy' config is set properly. See: 'npm help config'
79.92 npm error A complete log of this run can be found in: /root/.npm/_logs/2025-01-19T09_38_15_181Z-debug-0.log
------
Dockerfile:11
--------------------
9 |
10 | # Install pnpm globally
11 | >>> RUN npm install -g pnpm
12 |
13 | # Install dependencies
--------------------
ERROR: failed to solve: process "/bin/sh -c npm install -g pnpm" did not complete successfully: exit code: 1
With node-22: All works fine
—
Reply to this email directly, view it on GitHub
<#15 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE4COXF756HXOP64LZLGUAD2LNXKVAVCNFSM6AAAAABVJCNPM6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNRQHE2TSOBUGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@Adesoji1 The point i wanted to make is not to use node 18 or 22. I am using: Docker version 27.3.1, build ce12230 And for me command Do not work, i believe we can replace node-22-alpine to node-22 in line 2, as we have multi stage docker build, so we can keep node-22-alpine in line 26. The point i am trying to highlight is we use docker to make sure it just does not work only in your machine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Mohit21GoJs kindly test