Skip to content

Added docker.md, dockerfile and docker-compose.yaml#15

Open
Adesoji1 wants to merge 2 commits intoactualize-ae:mainfrom
Adesoji1:main
Open

Added docker.md, dockerfile and docker-compose.yaml#15
Adesoji1 wants to merge 2 commits intoactualize-ae:mainfrom
Adesoji1:main

Conversation

@Adesoji1
Copy link
Copy Markdown

@Mohit21GoJs kindly test

@Mohit21GoJs Mohit21GoJs self-requested a review January 17, 2025 08:25
@Mohit21GoJs
Copy link
Copy Markdown

@Adesoji1 Thanks for the efforts, let me review it and update here 👍

Comment thread Dockerfile
Comment thread Docker.md
@Adesoji1
Copy link
Copy Markdown
Author

Adesoji1 commented Jan 19, 2025 via email

@Mohit21GoJs
Copy link
Copy Markdown

@Adesoji1 The point i wanted to make is not to use node 18 or 22.

I am using:

Docker version 27.3.1, build ce12230
Docker Compose version v2.29.7

And for me command docker build --no-cache -t my-nextjs-app .

Do not work, i believe we can replace node-22-alpine to node-22 in line 2, as we have multi stage docker build, so we can keep node-22-alpine in line 26.

The point i am trying to highlight is we use docker to make sure it just does not work only in your machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants