feat: allow Chinese characters in project name#859
Open
LordofAvernus wants to merge 1 commit into
Open
Conversation
Use roleNameRule for project create form so names may start with Chinese and include Chinese characters, without relaxing shared nameRule used by data sources. Fixes actiontech/dms-ee#936
Coverage report
Test suite run success3742 tests passing in 820 suites. Report generated by 🧪jest coverage report action from f58a69f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nameRuletoroleNameRule.nameRuleunchanged so data source / member group / rule template names remain ASCII-only.Test plan
Fixes actiontech/dms-ee#936