feat: added python-version-strategy config option, to enable enforcing use of the lowest supported (approximate) version - #775
Conversation
…g use of the lowest supported (approximate) version
| } | ||
| } | ||
|
|
||
| if(versionStrategy == "approximate") |
There was a problem hiding this comment.
Might be better to make the versionStrategy directly take ~ as an argument, so that it can be used for all kinds of version overrides.
Not sure if there are uses for overriding the strategy to ^ however.
|
Hi @ErikBjare, Thanks for the contribution. The behavior this PR aims to override follows the action’s existing SemVer-based version resolution: a caret range like Users who want minimum-compatible behavior can express that directly with a narrower specifier such as Since the underlying feature request in #774 was closed as not planned on that basis, this PR does not have a path to merge. Closing this out accordingly. |
Description:
Adds a
python-version-strategyconfig option that enables overriding the version-picking strategy provided by the Python version specifier from>=and^to~.This is very useful when the version specified in
python-version-fileis a version constraint such as^3.8but where you usually want to test against the lowest supported version (with the highest patch version).Related issue:
Filed a feature request for this here: #774
Check list:
PRs I will merge if this change is accepted:
python_versionmatrix var with `python-version-file: p… ActivityWatch/aw-core#124python-version-fileActivityWatch/aw-client#80python_versionmatrix var with `python-version-file: p… ActivityWatch/aw-qt#101python_versionmatrix var with `python-version-file: p… ActivityWatch/aw-server#148python_versionmatrix var with `python-version-file: p… ActivityWatch/aw-watcher-afk#65python_versionmatrix var with `python-version-file: p… ActivityWatch/aw-watcher-window#93python_versionmatrix var with `python-version-file: p… ActivityWatch/aw-watcher-input#29