Scope test lockfiles by package manager and update cache tests#1495
Open
gowridurgad wants to merge 3 commits intoactions:mainfrom
Open
Scope test lockfiles by package manager and update cache tests#1495gowridurgad wants to merge 3 commits intoactions:mainfrom
gowridurgad wants to merge 3 commits intoactions:mainfrom
Conversation
added 2 commits
February 20, 2026 17:17
There was a problem hiding this comment.
Pull request overview
This PR restructures the test fixtures so lockfiles are scoped per package manager, updates cache-restore tests to point at the new fixture locations, and reduces fixture lockfile contents to eliminate qs-related security alerts picked up by dependency scanning.
Changes:
- Move npm/pnpm/yarn lockfiles into
__tests__/data/{npm|pnpm|yarn}/and add minimalpackage.jsonfixtures alongside them. - Update
__tests__/cache-restore.test.tsto setGITHUB_WORKSPACEper package manager fixture. - Add
.gitignorerules to ignore everything under fixture manager folders except the fixture manifests/lockfiles.
Reviewed changes
Copilot reviewed 4 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/data/yarn/yarn.lock | Adds a trimmed yarn lockfile fixture under the yarn-scoped directory. |
| tests/data/yarn/package.json | Adds a yarn fixture manifest (minimal deps + engines). |
| tests/data/yarn.lock | Removes the old shared yarn lockfile fixture from __tests__/data/. |
| tests/data/pnpm/pnpm-lock.yaml | Adds a trimmed pnpm lockfile fixture under the pnpm-scoped directory. |
| tests/data/pnpm/package.json | Adds a pnpm fixture manifest (minimal deps + engines). |
| tests/data/pnpm-lock.yaml | Removes the old shared pnpm lockfile fixture from __tests__/data/. |
| tests/data/package-lock.json | Removes the old shared npm lockfile fixture from __tests__/data/. |
| tests/data/npm/package.json | Adds an npm fixture manifest (minimal deps + engines). |
| tests/data/npm/package-lock.json | Adds a trimmed npm lockfile fixture under the npm-scoped directory. |
| tests/cache-restore.test.ts | Updates cache restore tests to set workspace to the appropriate fixture folder per package manager. |
| .gitignore | Ignores fixture folder contents while allowing fixture package.json + lockfiles to remain tracked. |
Files not reviewed (4)
- tests/data/npm/package-lock.json: Language not supported
- tests/data/package-lock.json: Language not supported
- tests/data/pnpm-lock.yaml: Language not supported
- tests/data/pnpm/pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
priyagupta108
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Split test fixtures per manager, update cache test lockfile paths, and resolve the qs security alerts.
Related issue:
https://github.com/actions/setup-node/security/dependabot/73
https://github.com/actions/setup-node/security/dependabot/74
https://github.com/actions/setup-node/security/dependabot/75
Check list: