Allow checking DNS with api.gihub.com.#4547
Open
TingluoHuang wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the runner’s job-level connectivity diagnostics by adding an optional “connectivity + DNS” check path, intended to capture DNS resolution timing/IPs in addition to HTTP reachability, and emit richer telemetry to help diagnose endpoint resolution issues.
Changes:
- Adds a new
ConnectivityAndDNSCheckspayload path to schedule background checks that include DNS resolution. - Enhances
CheckConnectivityto optionally resolve DNS, capture resolved IPs, and split timing into DNS vs HTTP request duration. - Adjusts emitted connectivity logs/telemetry formatting (JSON logging, new timing fields, status code prefixing).
Show a summary per file
| File | Description |
|---|---|
| src/Runner.Worker/JobExtension.cs | Adds background connectivity+DNS checks and extends connectivity check result/telemetry with DNS/IP/timing data. |
Review details
Comments suppressed due to low confidence (1)
src/Runner.Worker/JobExtension.cs:1212
CheckServiceConnectivityAsyncstill treats only "OK" and "canceled" as non-failures, butCheckConnectivitynow prefixes HTTP results (e.g.http_OK,http_canceled). This will incorrectly mark successful connectivity checks as failures and may cause misleading telemetry.
if (!testResult.HasFailure &&
result.StatusCode != "OK" &&
result.StatusCode != "canceled")
{
- Files reviewed: 1/1 changed files
- Comments generated: 5
- Review effort level: Low
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/github/actions-runtime/issues/5556