Allow disable node v8 maglev jit compiler on node24.#4447
Open
TingluoHuang wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a targeted workaround in the JavaScript action handler to mitigate a Node.js 24 / V8 Maglev issue on Windows runners by conditionally disabling Maglev JIT at process startup, with an opt-out via an environment variable.
Changes:
- Detect Node 24 runtime on Windows x64 and prepend
--no-maglevto the Node invocation arguments. - Allow re-enabling Maglev via
ACTIONS_RUNNER_REENABLE_NODE_MAGLEVset either at the machine/process level or step-level env.
Show a summary per file
| File | Description |
|---|---|
| src/Runner.Worker/Handlers/NodeScriptActionHandler.cs | Conditionally adds --no-maglev to Node 24 invocation on Windows x64, with env-var override. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
Comment on lines
+134
to
+138
| if (nodeRuntimeVersion.StartsWith("node24", StringComparison.OrdinalIgnoreCase) && | ||
| Constants.Runner.Platform == Constants.OSPlatform.Windows && | ||
| Constants.Runner.PlatformArchitecture == Constants.Architecture.X64 && | ||
| !StringUtil.ConvertToBoolean(System.Environment.GetEnvironmentVariable("ACTIONS_RUNNER_REENABLE_NODE_MAGLEV")) && | ||
| !StringUtil.ConvertToBoolean(Environment.GetValueOrDefault("ACTIONS_RUNNER_REENABLE_NODE_MAGLEV"))) |
yacaovsnc
previously approved these changes
May 26, 2026
Contributor
|
Do you want to change behavior after the env is set? Up to you. |
yacaovsnc
previously approved these changes
May 26, 2026
TingluoHuang
force-pushed
the
users/tihuang/nodemaglev
branch
from
3059c43 to
c01332a
Compare
TingluoHuang
changed the title
lokesh755
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to workaround nodejs/node#62260 for actions/runner on Windows
Setting machine level env
ACTIONS_RUNNER_DISABLE_NODE_MAGLEV=1or step level envACTIONS_RUNNER_DISABLE_NODE_MAGLEV=1