Add format string validation in expressions package #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsciple
force-pushed
the
users/ericsciple/26-01-format2
branch
from
28df68e to
8c82b7b
Compare
Format string validation now happens at parse time in the Parser: - Invalid format string syntax throws ErrorInvalidFormatString - Argument count mismatch throws ErrorFormatArgCountMismatch This catches errors early and automatically for all consumers.
ericsciple
force-pushed
the
users/ericsciple/26-01-format2
branch
from
8c82b7b to
9f260c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Format string validation at parse time:
ErrorInvalidFormatStringErrorFormatArgCountMismatchThis catches errors early and automatically for all consumers.