feat: v1.0 data model — add missing proto fields#14
Open
zeroasterisk wants to merge 3 commits intoactioncard:mainfrom
Open
feat: v1.0 data model — add missing proto fields#14zeroasterisk wants to merge 3 commits intoactioncard:mainfrom
zeroasterisk wants to merge 3 commits intoactioncard:mainfrom
Conversation
Contributor
|
I’ll take a look at the CI issue, it’s my issue to fix it seems like. |
Contributor
|
@zeroasterisk I fixed the CI issues, tested on #12. Feel free to rebase and we can check it out here too. |
New structs: - A2A.AuthenticationInfo (scheme, credentials) - A2A.AgentExtension (uri, description, required, params) - A2A.AgentCardSignature (protected, signature, header) - A2A.TaskPushNotificationConfig (tenant, id, task_id, url, token, authentication) - A2A.SendMessageConfiguration (accepted_output_modes, task_push_notification_config, history_length, return_immediately) Updated structs (additive only): - AgentCard: +signatures, +security_requirements - AgentCard skill type: +examples, +input_modes, +output_modes, +security_requirements - AgentCard capabilities: +extensions (repeated AgentExtension) - AgentCard supported_interface: +tenant - Message: extensions changed from map to list (per proto repeated string), +reference_task_ids - Artifact: +extensions (repeated string) - Part.Text/File/Data: +media_type, +filename JSON codec updates: - Encode/decode all new fields - Support v1.0 flat Part format (raw/url without file wrapper) in decoding - Encode/decode new structs (AuthenticationInfo, TaskPushNotificationConfig, SendMessageConfiguration, AgentExtension, AgentCardSignature) - Skill encode/decode includes examples, inputModes, outputModes, securityRequirements All changes verified against a2a.proto HEAD. No breaking changes. Part of actioncard#13
38 new tests covering: - AuthenticationInfo encode/decode - AgentExtension encode/decode - AgentCardSignature encode/decode - TaskPushNotificationConfig encode/decode - SendMessageConfiguration encode/decode - Message reference_task_ids and list extensions - Artifact extensions - Part media_type and filename on all part types - v1.0 flat Part format (raw/url) decoding - AgentCard signatures, security_requirements - AgentCard skill v1.0 fields (examples, input/output modes) - AgentCard capabilities extensions (AgentExtension) - AgentCard interface tenant field - TaskState enum round-trip for all 9 states - Backward compatibility with v0.3 format
- Add to_map/1 for JSON-friendly map conversion (needed by signing module)
- Fix signing_test to use %AgentCard{} struct directly instead of missing new/1
- Fix Skill reference: use plain map instead of non-existent AgentCard.Skill struct
zeroasterisk
force-pushed
the
feat/v1-data-model
branch
from
6db2987 to
25326bc
Compare
Author
|
Rebased onto latest main and pushed. Fixed a couple of issues that surfaced after rebase:
Tests: 431 pass, 6 failures — all 6 are pre-existing on main (3 signing tests need optional |
TCK Compliance Results |
Contributor
|
Nice fixing! After this first PR of yours gets merged @zeroasterisk you will be an approved author and the other PR workflows will run directly. A bit inconvenient this first time, but I'll pay extra attention to the notifications so we can get this merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #13 (A2A v1.0 Protocol Support)
Adds v1.0 fields to existing structs while maintaining full v0.3 backward compatibility. All changes verified against
a2a.protoHEAD.New Structs
A2A.AuthenticationInfo— HTTP auth scheme + credentials for push notificationsA2A.AgentExtension— protocol extension declaration (uri, description, required, params)A2A.AgentCardSignature— JWS signature (RFC 7515) for agent cardsA2A.TaskPushNotificationConfig— push notification configuration per taskA2A.SendMessageConfiguration— send request config (accepted_output_modes, history_length, return_immediately)Updated Structs (additive only, no breaking changes)
signatures, +security_requirementsexamples, +input_modes, +output_modes, +security_requirementsextensions(repeated AgentExtension)tenantextensionschanged from map to list (per protorepeated string), +reference_task_idsextensions(repeated string)media_type, +filenameJSON Codec
raw/urlwithoutfilewrapper) in decodingTests
No breaking changes — new fields have sensible defaults.
Fixes part of #13