Skip to content

feat(cp): error when some targeted pods are not running#79

Merged
acmore merged 1 commit intomainfrom
feat/cp-readiness-check
Apr 14, 2026
Merged

feat(cp): error when some targeted pods are not running#79
acmore merged 1 commit intomainfrom
feat/cp-readiness-check

Conversation

@acmore
Copy link
Copy Markdown
Owner

@acmore acmore commented Apr 14, 2026

Summary

  • Add pod readiness check to multi-pod cp, matching exec's existing behavior
  • When some targeted pods aren't running, error with a list of non-ready pods (name + phase) instead of silently skipping them
  • Add --ready-only flag to opt into copying only to/from running pods
  • Reorder filtering to apply user selectors (name/role/label/exclude) before the readiness check, so the error denominator reflects only targeted pods

Test plan

  • Existing cp unit tests pass
  • New readiness check tests: error message format, role-scoped denominator, all-running happy path, none-running error, --ready-only bypass
  • e2e: okdev cp --all with mixed-phase pods errors without --ready-only
  • e2e: okdev cp --all --ready-only succeeds on running subset

🤖 Generated with Claude Code

Match exec's readiness check behavior: when multi-pod cp targets pods
that aren't running, error with a list of non-ready pods and suggest
--ready-only to proceed with only the running subset. Previously cp
silently filtered to running pods, hiding partial failures.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@acmore acmore merged commit 706fd0c into main Apr 14, 2026
1 check passed
@acmore acmore deleted the feat/cp-readiness-check branch April 14, 2026 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant