fix(batch): disable mpv audio only for offline vr hybrid mode#131
Open
hwoarangc wants to merge 1 commit into
Open
fix(batch): disable mpv audio only for offline vr hybrid mode#131hwoarangc wants to merge 1 commit into
hwoarangc wants to merge 1 commit into
Conversation
- add runtime set_audio_enabled() to mpv GL/SW display backends - disable mpv audio only when batch mode is OFFLINE_VR_HYBRID_CHAPTER - keep mpv audio behavior unchanged for other batch trackers - restore mpv audio state from audio.enabled when batch exits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR prevents AUDCLNT_E_DEVICE_INVALIDATED during batch runs by disabling mpv audio only for offline VR hybrid mode, not globally for all batch trackers.
Why
The WASAPI error comes from audio endpoint invalidation. For offline VR hybrid, audio output is unnecessary and can interrupt long batch runs. Other trackers may still need audio behavior, so this change keeps their default behavior intact.
Changes