fix: #93 --requirements and --project flags ignored upgrade_type#94
Open
max-nicholson wants to merge 3 commits intoachillesrasquinha:masterfrom
Open
fix: #93 --requirements and --project flags ignored upgrade_type#94max-nicholson wants to merge 3 commits intoachillesrasquinha:masterfrom
--requirements and --project flags ignored upgrade_type#94max-nicholson wants to merge 3 commits intoachillesrasquinha:masterfrom
Conversation
If `--requirements` or `--project` flags are used, current_version for Packages was equal to the specifier in the requirements file eg. requests==2.24.0 showed current_version as `==2.24.0` rather than just `2.24.0` This then caused the `upgrade_type` check later to fail (as the `==` version prefix made the version difference calculation incorrect Requirements will now include the version only if an exact version is specified, otherwise the installed version is used. If not installed, the entire specifier is used (eg. `~=1.0`)
`test_command` hangs forever on Windows (see achillesrasquinha#78), so CI runs for the full 6hrs for each Windows run Until achillesrasquinha#78 is resolved, test should be skipped so the Windows CI can at least test the rest of the codebase
max-nicholson
changed the title
--requirements and --project flags ignored upgrade_type
Contributor
Author
|
Noticed while looking at this that https://github.com/achillesrasquinha/pipupgrade/blob/1ec3d5fd779fd8aff008be1fe2ec72888a8cd494/src/pipupgrade/commands/helper.py#L265, when we get the final list of packages to show the user in the interactive window, the Wasn't sure if it's safe to combine into one large |
InstallRequirement.__str__ method is called during Package.__init__ for logging. __str__ with no `req` on pip 9 returned None, causing an error __str__ on pip >9 still returned a string, so worked fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #93
Proposed Changes
If
--requirementsor--projectflags are used, current_version forPackages was equal to the specifier in the requirements file
eg. requests==2.24.0 showed current_version as
==2.24.0rather thanjust
2.24.0This then caused the
upgrade_typecheck later to fail (as the==version prefix made the version difference calculation incorrect
Requirements will now include the version only if an exact version is
specified, otherwise the installed version is used.
If not installed, the entire specifier is used (eg.
~=1.0)test_commandhangs forever on Windows (see Cannot run on Windows10 #78), so CI runs forthe full 6hrs for each Windows run. Until Cannot run on Windows10 #78 is resolved, test should be skipped so the Windows CI can at least test the rest of the codebase