fix: put requests with application/x-www-form-urlencoded is incorrect…#1341
fix: put requests with application/x-www-form-urlencoded is incorrect…#1341iandyh wants to merge 1 commit intoacacode:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 24704ea The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
iandyh
force-pushed
the
main
branch
4 times, most recently
from
f5d92b7 to
9b8d877
Compare
This comment was marked as outdated.
This comment was marked as outdated.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@smorimoto thanks for checking. I need further verification of the change since I notice something suspicious with this fix. I'll update you once I finish the confirmation. |
|
@smorimoto I've verified the changes and they are good to go. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback". |
2 participants
…ly handled
I was facing this issue with
swagger-typescript-api@13.2.7.For a
PUTrequest expectingapplication/x-www-form-urlencoded, The generated swagger.json has the correct config:However, the generated code incorrectly set the request to be sent with
multipart/form-data.fyi: the code is entirely generated by
Github Copilot.