Add support for Reference Fix Commits improver#2163
Open
ziadhany wants to merge 8 commits intoaboutcode-org:mainfrom
Open
Add support for Reference Fix Commits improver#2163ziadhany wants to merge 8 commits intoaboutcode-org:mainfrom
ziadhany wants to merge 8 commits intoaboutcode-org:mainfrom
Conversation
ziadhany
force-pushed
the
collect-package-patch
branch
from
b9b3fe1 to
ae2b35a
Compare
Update the pipeline and fix the test Signed-off-by: ziad hany <ziadhany2016@gmail.com>
ziadhany
force-pushed
the
collect-package-patch
branch
from
ae2b35a to
8bf03c1
Compare
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
ziadhany
force-pushed
the
collect-package-patch
branch
from
8bf03c1 to
374de5e
Compare
Collaborator
Author
|
Pipeline Logs: |
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
ziadhany
commented
Feb 20, 2026
vulnerabilities/tests/pipelines/v2_improvers/test_reference_collect_commits_v2.py
Outdated
Show resolved
Hide resolved
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
TG1999
reviewed
Feb 24, 2026
| None | ||
| """ | ||
| purl = url2purl(url) | ||
| if not purl or purl.type not in VCS_URLS_SUPPORTED_TYPES: |
Contributor
There was a problem hiding this comment.
What's the reason to do
purl.type not in VCS_URLS_SUPPORTED_TYPES:
When we are already doing url2purl(purl) to ensure we get a package. Also put it in try except block with a logger.
TG1999
reviewed
Feb 24, 2026
vulnerabilities/pipelines/v2_improvers/reference_collect_commits.py
Outdated
Show resolved
Hide resolved
TG1999
requested changes
Feb 24, 2026
Contributor
TG1999
left a comment
TG1999
left a comment
There was a problem hiding this comment.
Nits for your consideration
| total_iterations=impacted_packages_advisories.count(), logger=self.log | ||
| ) | ||
| for adv in progress.iter(impacted_packages_advisories.paginated(per_page=500)): | ||
| urls = {r.url for r in adv.references.all()} | {p.patch_url for p in adv.patches.all()} |
Contributor
There was a problem hiding this comment.
refs = adv.references.values_list("url", flat=True)
patches = adv.patches.values_list("patch_url", flat=True)
urls = set(refs) | set(patches)
Fetch only needed columns ?
| vcs_url, commit_hash = vcs_data | ||
| package_commit_obj, _ = PackageCommitPatch.objects.get_or_create( | ||
| vcs_url=vcs_url, commit_hash=commit_hash | ||
| ) |
Contributor
There was a problem hiding this comment.
Can we handle this at bulk level, and avoid get or create and addition in a loop ?
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: