Security: Sensitive Token Data Exposure in Migration Logging#2177
Open
tomaioo wants to merge 1 commit into
Open
Security: Sensitive Token Data Exposure in Migration Logging#2177tomaioo wants to merge 1 commit into
tomaioo wants to merge 1 commit into
Conversation
Migration 0079_apitoken_data.py prints the count of migrated tokens with `print(f" -> {len(migrated_tokens)} tokens migrated.")`. While this only logs the count, the migration handles sensitive API token data. More importantly, the migration reads plaintext tokens from the `authtoken_token` table and hashes them with `make_password(key)`. The use of `print()` in migrations can leak information to logs, and the migration's handling of plaintext tokens should ensure no token values are ever logged.
Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Sensitive Token Data Exposure in Migration Logging
Problem
Severity:
Low| File:scanpipe/migrations/0079_apitoken_data.py:L35Migration 0079_apitoken_data.py prints the count of migrated tokens with
print(f" -> {len(migrated_tokens)} tokens migrated."). While this only logs the count, the migration handles sensitive API token data. More importantly, the migration reads plaintext tokens from theauthtoken_tokentable and hashes them withmake_password(key). The use ofprint()in migrations can leak information to logs, and the migration's handling of plaintext tokens should ensure no token values are ever logged.Solution
Remove the print statement or replace it with proper logging at an appropriate level. Ensure that no token values, prefixes, or hashes are ever logged. Consider using Django's migration logging framework instead of print().
Changes
scanpipe/migrations/0079_apitoken_data.py(modified)