Skip to content

Fix empty range in terminate_pool_with_backoff making it a no-op #4784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codewithfourtix wants to merge 3 commits into
base: develop
Choose a base branch
from
+46 −1
Open

Fix empty range in terminate_pool_with_backoff making it a no-op #4784

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7337829
Fix empty range in terminate_pool_with_backoff making it a no-op
codewithfourtix Mar 1, 2026
73e8d33
Add regression tests for terminate_pool_with_backoff retry loop
codewithfourtix Mar 2, 2026
8a6fea8
Fix tests for terminate_pool_with_backoff to resolve WindowsError sc…
codewithfourtix Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/scancode/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1390,7 +1390,7 @@ def terminate_pool(pool):

def terminate_pool_with_backoff(pool, number_of_trials=3):
# try a few times to terminate,
for trial in range(number_of_trials, 1):
for trial in range(number_of_trials):
try:
Comment thread
codewithfourtix marked this conversation as resolved.
pool.terminate()
break
Expand Down
Loading