-
-
Notifications
You must be signed in to change notification settings - Fork 682
Fix #4576: Add BSD license detection rule for JLine XML comments #4681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Fix #4576: Add BSD license detection rule for JLine XML comments #4681
Conversation
|
@Kannan-3757 The original issue (BSD license not detected in JLine packages) is now resolved. The The current CI failure in
The BSD license detection for JLine packages is working as required and is ready for review.. |
|
Summary: Adds BSD license detection for JLine packages where the license is declared in XML comments instead of standard Maven Status: The CI failure in @pombredanne @AyanSinhaMahapatra - Ready for review when you have time! |
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Jayant-kernel see comments for your consideration
| Appears in jline-console, jline-style, and jline-reader modules. | ||
| --- | ||
|
|
||
| Copyright (c) 2002-2020, the original author or authors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove the copyright line? This is not useful for the license rule
| --- | ||
|
|
||
| Copyright (c) 2002-2020, the original author or authors. | ||
| This software is distributable under the BSD license. See the terms of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| This software is distributable under the BSD license. See the terms of the | |
| This software is {{distributable under the BSD license}}. See the terms of the |
Use required phrases whenever applicable to reduce false positives.
| Copyright (c) 2002-2020, the original author or authors. | ||
| This software is distributable under the BSD license. See the terms of the | ||
| BSD license in the documentation provided with this software. | ||
| https://opensource.org/licenses/BSD-3-Clause |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| https://opensource.org/licenses/BSD-3-Clause | |
| {{https://opensource.org/licenses/BSD-3-Clause}} |
Same as above
|
@AyanSinhaMahapatra Put the copyright line in ignorable_copyrights instead of the rule body Should be good now! |
Add proper BSD detection rule for JLine style XML comments. Detects BSD-3-Clause in POM files. Includes validation fixes and correct metadata fields. Signed-off-by: Jayant Saxena <jayantmcom@gmail.com>
7618315 to
3775292
Compare
Add proper BSD detection rule for JLine style XML comments. Detects BSD-3-Clause in POM files. Includes validation fixes and correct metadata fields. Signed-off-by: Jayant Saxena <jayantmcom@gmail.com>
3775292 to
798d94d
Compare
Add proper BSD detection rule for JLine style XML comments. Detects BSD-3-Clause in POM files. Includes validation fixes and correct metadata fields. Signed-off-by: Jayant Saxena <jayantmcom@gmail.com>
798d94d to
8678202
Compare
Fixes #4576
Problem
ScanCode wasn't detecting the BSD-3-Clause license in JLine packages (jline-console, jline-style, jline-reader) because the license is in XML comments instead of the usual Maven tags.
Solution
Added a detection rule bsd-new_jline_xml.RULE to catch the BSD license pattern used in JLine POM files.
Testing
Tested on jline-console-3.30.4-sources.jar:
License detected: BSD-3-Clause
Rule used: bsd-new_jline_xml.RULE
The same pattern shows up in jline-style and jline-reader, so this covers all three packages.
Changes
Added src/licensedcode/data/rules/bsd-new_jline_xml.RULE with proper metadata fields for copyright, holders, and URLs per maintainer feedback.
The license appears in POM files as:
xml
ScanCode now picks this up correctly.
Checklist:
Reviewed contribution guidelines
PR links to original issue
Tests pass
Feature branch with no merge conflicts
Updated CHANGELOG.rst (if needed)
Signed-off-by: Jayant Saxena jayantmcom@gmail.com