feat: add create_dependencies option to all import forms#540
Merged
Conversation
Signed-off-by: tdruez <tdruez@aboutcode.org>
Signed-off-by: tdruez <tdruez@aboutcode.org>
Signed-off-by: tdruez <tdruez@aboutcode.org>
Signed-off-by: tdruez <tdruez@aboutcode.org>
Contributor
|
@tdruez Is there a particular reason why this is suddenly being disable by default? This is a breaking change for us and I need to patch this to enable it by default. |
Contributor
Author
|
@rogu-beta Thanks for reporting, I'll push a fix today. |
Contributor
|
@tdruez Take your time, we are not in a hurry. I've already patched our fork. I was mostly asking to understand why this change was made. |
Contributor
Author
|
@rogu-beta Importing dependencies by default was problematic for large scans containing hundreds of thousands of dependencies, which were blocking the package import entirely. Reverted to an opt-in checkbox (unchecked by default) and introduced a Fixed in #546 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
create_dependenciesboolean field (default: False) to all product import forms (ImportFromScanForm, PullProjectDataForm, LoadSBOMsForm, ImportManifestsForm) so users must explicitly opt in to importing dependencyrelationships.