Fix missing RoleReconciler ClusterRole secrets verbs as the reconciler is watching referenced Secrets
#21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ciler is watching referenced Secrets
There was a problem hiding this comment.
Pull request overview
This PR addresses a missing RBAC configuration for the RoleReconciler component, which requires permissions to watch Secret resources but lacks the necessary ClusterRole verbs.
Changes:
- Added a workaround in the release workflow to patch the ClusterRole with required secrets permissions
- Documented the JOSDK limitation preventing the standard RBAC configuration approach
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| operator/src/main/resources/application.yml | Documents the attempted RBAC configuration and known JOSDK limitation with commented-out config |
| .github/workflows/release.yml | Implements a yq patch step to add secrets verbs to the rolereconciler-cluster-role during release |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ThoSap
deleted the
fix-missing-role-reconciler-secrets-cluster-role-binding
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Report a Quarkus JOSDK bug as configuring the
quarkus.kubernetes.rbac.cluster-role* properties or adding theClusterRoleandClusterRoleBindinginoperator/src/main/kubernetes/kubernetes.ymldoes not work, JOSDK simply ignores theClusterRoleBindingwhen creating the final Helm chart, but it adds theClusterRole.See the https://quarkus.io/guides/all-config