feat(table): wire Table.delete() to merge-on-read position deletes#29
Open
abnobdoss wants to merge 3 commits into
Open
feat(table): wire Table.delete() to merge-on-read position deletes#29abnobdoss wants to merge 3 commits into
abnobdoss wants to merge 3 commits into
Conversation
added 3 commits
June 23, 2026 22:31
When write.delete.mode=merge-on-read on a format-version 2 table, Transaction.delete(predicate) now produces position deletes (via the PR2 writer + row-delta producer) instead of warning and falling back to copy-on-write. Copy-on-write remains the default; merge-on-read is opt-in. _delete_merge_on_read scans each matched data file's RAW physical rows (no delete files applied), assigns 0-based positions, applies the predicate, subtracts positions already covered by existing delete files (idempotent), and commits one position-delete file per data file as a single OVERWRITE row-delta snapshot. Data files are never rewritten; the delete inherits the new snapshot sequence number so it cannot apply to data appended afterward. Non-v2 tables under merge-on-read still warn and fall back to copy-on-write.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.