fix(manifest): use LongType for positional-delete pos field per spec#27
Open
abnobdoss wants to merge 3 commits into
Open
fix(manifest): use LongType for positional-delete pos field per spec#27abnobdoss wants to merge 3 commits into
abnobdoss wants to merge 3 commits into
Conversation
added 3 commits
June 23, 2026 17:58
The position-delete `pos` field (id 2147483545) is specified as a long, but pyiceberg typed it as IntegerType (int32). Data files with more than 2**31 rows would overflow the position on write/read. Correct it to LongType per the Iceberg spec and add round-trip coverage for positions above the int32 range.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.