chore(catalog): dispose in-memory catalog engines and clear Python 3.13 deprecation warnings#16
Open
abnobdoss wants to merge 5 commits into
Open
chore(catalog): dispose in-memory catalog engines and clear Python 3.13 deprecation warnings#16abnobdoss wants to merge 5 commits into
abnobdoss wants to merge 5 commits into
Conversation
…ines in tests The 'unclosed database in <sqlite3.Connection>' ResourceWarning under Python 3.13 was suppressed via a pytest filterwarnings ignore (apache#2863). Root cause: test fixtures and tests created SqlCatalog instances (each opening a SQLAlchemy engine / sqlite connection pool) without ever calling the existing SqlCatalog.close() (added in apache#2390), so the pooled sqlite connections leaked and emitted ResourceWarning during GC. Wire close()/engine.dispose() into the relevant fixtures and tests and remove the now-unnecessary sqlite ResourceWarning filter. The ray and google (api_core / crc32c) filters remain, as those originate in those dependencies, not pyiceberg.
InMemoryCatalog is a SqlCatalog backed by sqlite:///:memory:, so its local test fixtures and load_catalog(type=in-memory) usages leaked sqlite connections (ResourceWarning under Python 3.13). Convert the local 'catalog' fixtures to yield+close and close the catalog created by test_load_catalog_in_memory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.