Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThis pull request introduces a new Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/commands/apps/channel-rules/update.ts`:
- Around line 166-174: The code currently sets updateData.persisted = true and
emits the warning whenever flags["mutable-messages"] is present (including
--no-mutable-messages); change the condition so the persisted override and the
warning only run when flags["mutable-messages"] === true, i.e., explicitly
enabling mutable messages. Also reuse the same warning text/constant used in
create.ts (import or reference that constant) instead of duplicating the string,
and wrap the this.logToStderr(...) call in if (!this.shouldOutputJson(flags)) so
the warning is suppressed for --json output; keep the assignment to
updateData.mutableMessages = flags["mutable-messages"] as-is.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 32ed5959-7578-45a3-b8fd-4faaf2560a39
📒 Files selected for processing (8)
src/commands/apps/channel-rules/create.tssrc/commands/apps/channel-rules/list.tssrc/commands/apps/channel-rules/update.tssrc/services/control-api.tssrc/utils/channel-rule-display.tstest/unit/commands/apps/channel-rules/create.test.tstest/unit/commands/apps/channel-rules/list.test.tstest/unit/commands/apps/channel-rules/update.test.ts
549ff4b to
71010bc
Compare
71010bc to
6a7750f
Compare
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on April 4. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
There was a problem hiding this comment.
Pull request overview
Adds support for the Ably “mutable messages” channel rule capability across the CLI’s channel-rules commands, including create/update flags, list/detail display, and JSON output, with tests covering the new behavior.
Changes:
- Add
--mutable-messagessupport toapps:channel-rules:createandapps:channel-rules:update, including auto-enabling persistence when enabled. - Include
mutableMessagesin channel rule list/details output and JSON output. - Extend Control API namespace typings and add unit tests for create/update/list scenarios.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| test/unit/commands/apps/channel-rules/update.test.ts | Adds tests for updating mutable messages, persistence enforcement, and JSON output. |
| test/unit/commands/apps/channel-rules/list.test.ts | Adds tests ensuring mutableMessages shows in human output and JSON output. |
| test/unit/commands/apps/channel-rules/create.test.ts | Adds tests for create with mutable messages, persistence auto-enable, and JSON behavior. |
| src/utils/channel-rule-display.ts | Adds “Mutable Messages” line to human-readable channel rule details when present. |
| src/services/control-api.ts | Extends Namespace and namespace create/update payload types with mutableMessages. |
| src/commands/apps/channel-rules/update.ts | Introduces --mutable-messages flag, validation, persistence auto-enable, and JSON output field. |
| src/commands/apps/channel-rules/list.ts | Adds mutableMessages to JSON output mapping for list. |
| src/commands/apps/channel-rules/index.ts | Updates examples to mention mutable messages. |
| src/commands/apps/channel-rules/create.ts | Introduces --mutable-messages flag and persistence auto-enable + warning behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5947caa to
7716fe8
Compare
Summary by CodeRabbit
Release Notes
New Features
--mutable-messagesflag to enable mutable messaging for channel rules during creation and updates.Improvements