renamed module_name and target_name#12
Closed
farfromrefug wants to merge 8 commits intoabandonware:masterfrom
Closed
renamed module_name and target_name#12farfromrefug wants to merge 8 commits intoabandonware:masterfrom
farfromrefug wants to merge 8 commits intoabandonware:masterfrom
Conversation
|
Thanks but you need to rebase on master and resolv changes , may you split this change set and submit atomic changes ? |
|
Please rebase or submit smaller changes in other PR |
|
This was handled in #13. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As asked i forwarded the PR. Though i am not using this right now so can't really update it. Is that enough?