fix local env B related artificial spikes#207
Open
ahnyu wants to merge 2 commits intoabacusorg:mainfrom
Open
Conversation
Member
|
Thanks @ahnyu! I think this sounds reasonable. @SandyYuan Are you available to take a look at this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the local environment calculation used by the assembly-bias parameters (Bcent, Bsat). The issue was that Menv was estimated independently within each superslab, so halos close to a superslab boundary were missing neighboring halos from adjacent superslabs. This led to incorrect Menv values near slab edges and introduced an artificial x-dependent striping pattern in the derived fenv field.
The fix is:
This fix is for box, the light-cone approach is unchanged.
Included are before/after plots showing the clustering signal (Pk), galaxy counts along each axis.