Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
AGMASO
approved these changes
Mar 5, 2026
mgrabina
approved these changes
Mar 5, 2026
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the dashboard list configuration to hide a specific asset (aCRED) on the proto_horizon_v3 market, addressing an asset-listing issue.
Changes:
- Uncomments/enables the
proto_horizon_v3entry inHIDDEN_ASSETS - Adds the aCRED underlying asset address to the hidden-assets list
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+4
to
+6
| [CustomMarket.proto_horizon_v3]: [ | ||
| '0x17418038ecf73ba4026c4f428547bf099706f27b'.toLowerCase(), // aCRED | ||
| ], |
There was a problem hiding this comment.
The hidden-asset entry relies on a bare address literal with only a trailing comment for context. Consider extracting this address into a named constant (e.g., ACRED_UNDERLYING), and/or adding a short comment explaining why it must be hidden (e.g., deprecated asset, incorrect listing, etc.) to make future audits safer and reduce accidental removal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General Changes
Developer Notes
Add any notes here that may be helpful for reviewers.
Reviewer Checklist
Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.
.env.examplefile as well as the pertinant.github/actions/*files