feat!: Update to next 16.4#689
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Code Review
This pull request involves a significant update of dependencies across the repository, including transitions to TypeScript 6.0 and ESLint 10, and refactors various components and hooks to align with new linting standards. Notable changes include the introduction of an onReset method in the useCaptcha hook and UI logic refinements in the combobox-async and order-table-head components. Feedback indicates that resolvedTheme should be added to the useEffect dependency array in the useCaptcha hook to ensure the Cloudflare Turnstile widget re-renders correctly upon theme changes.
| } | ||
| }; | ||
| // eslint-disable-next-line @eslint-react/exhaustive-deps | ||
| }, [pathname, locale, captcha?.type, captcha?.siteKey]); |
There was a problem hiding this comment.
The useEffect hook is missing resolvedTheme in its dependency array. Since the Cloudflare Turnstile widget is rendered using the resolvedTheme value (line 68), the widget will not update its appearance if the user switches between light and dark modes after the initial load. Adding resolvedTheme to the dependencies will ensure the widget is re-rendered with the correct theme when it changes.
| }, [pathname, locale, captcha?.type, captcha?.siteKey]); | |
| }, [pathname, locale, captcha?.type, captcha?.siteKey, resolvedTheme]); |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b92e959b11
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "module": "esnext", | ||
| "moduleResolution": "bundler", | ||
| "rootDir": "./", | ||
| "rootDir": "./src", |
There was a problem hiding this comment.
Restore rootDir to include global.d.ts
Setting compilerOptions.rootDir to ./src while still including global.d.ts from the package root makes tsc treat that file as outside the root directory, which triggers TS6059 during plugin builds. In this repo, plugins/blog/tsconfig.json explicitly includes global.d.ts, so this change can break build:plugins/declaration generation for the blog plugin until rootDir covers both src and global.d.ts (or the declaration file is moved).
Useful? React with 👍 / 👎.
Improving Documentation
pnpm lint:fixto fix formatting issues before opening the PR.Description
What?
Why?