fix: use threading.RLock for in-memory server singletons - #1162
Open
mykytanetipa wants to merge 2 commits into
Open
fix: use threading.RLock for in-memory server singletons#1162mykytanetipa wants to merge 2 commits into
mykytanetipa wants to merge 2 commits into
Conversation
🧪 Code Coverage (vs
|
ishymko
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The in-memory server singletons guard their state with an asyncio.Lock, which binds to the first event loop that awaits it. A server that uses these singletons from more than one event loop then hits "RuntimeError: ... is bound to a different event loop" (or a cross-loop hang).
Replace the asyncio.Lock with a loop-agnostic threading.RLock in InMemoryQueueManager, ActiveTaskRegistry, InMemoryTaskStore, InMemoryPushNotificationConfigStore, and the request handler's _running_agents guard, moving awaited calls outside the lock so each critical section is a pure in-memory dict operation.
Behavior is unchanged for single-loop servers; only the private lock attribute's type changes.
Tests: added tests/server/test_cross_event_loop_locks.py (cross-loop regression) and updated the test_init lock-type assertion.