Skip to content

fix(rest): map invalid history length to InvalidParamsError #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ehsavoie merged 10 commits into from
Mar 12, 2026
Merged

fix(rest): map invalid history length to InvalidParamsError #715

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c41100d
fix(rest): map invalid history length to InvalidParamsError
Zhang-Charlie Mar 9, 2026
758f24e
fix(rest): scope historyLength validation handling in getTask
Zhang-Charlie Mar 9, 2026
3ac5f90
fix(cloud-deployment): use Strimzi-supported Kafka version
Zhang-Charlie Mar 9, 2026
ad84170
Revert "fix(cloud-deployment): use Strimzi-supported Kafka version"
Zhang-Charlie Mar 9, 2026
4d7cb1d
Merge branch 'main' into fix/rest-historylength-validation
ehsavoie Mar 9, 2026
91fd77d
Merge branch 'main' into fix/rest-historylength-validation
Zhang-Charlie Mar 9, 2026
c2bbaab
fix(rest): return problem+json for historyLength validation errors
Zhang-Charlie Mar 9, 2026
c330b8c
Merge branch 'main' into fix/rest-historylength-validation
ehsavoie Mar 10, 2026
105345a
fix: throw InvalidParamsError instead of wrapping in problem response
Zhang-Charlie Mar 10, 2026
a32ae7d
refactor(rest): remove duplicate createProblemErrorResponse in RestHa…
Zhang-Charlie Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions transport/rest/src/main/java/io/a2a/transport/rest/handler/RestHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,8 @@ public HTTPRestResponse getTask(ServerCallContext context, String tenant, String
return createSuccessResponse(200, io.a2a.grpc.Task.newBuilder(ProtoUtils.ToProto.task(task)));
}
throw new TaskNotFoundError();
} catch (IllegalArgumentException e) {
return createErrorResponse(new InvalidParamsError(e.getMessage()));
} catch (A2AError e) {
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Catching the generic IllegalArgumentException is a bit risky here. While it correctly handles the invalid historyLength case from TaskQueryParams, it could also catch IllegalArgumentException thrown from other parts of the try block (e.g., a bug in an implementation of requestHandler.onGetTask). Such cases would indicate a server-side issue and should result in a 500 error, but would be incorrectly reported as a 422 client error.

To make this more robust, you could check the exception message to ensure you're only handling the specific error you expect. This avoids masking potential server-side bugs.

        } catch (IllegalArgumentException e) {
            if ("Invalid history length".equals(e.getMessage())) {
                return createErrorResponse(new InvalidParamsError(e.getMessage()));
            }
            throw e;
        }

Copy link
Copy Markdown
Contributor Author

@Zhang-Charlie Zhang-Charlie Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. I agree with the concern about catching IllegalArgumentException too broadly.

I updated the implementation to scope the IllegalArgumentException handling to only the TaskQueryParams construction path, so only parameter-validation failures map to InvalidParamsError (422). Exceptions from downstream logic (e.g., requestHandler.onGetTask) are no longer reclassified as client errors.

Updated in commit 758f24e on this PR branch.

return createErrorResponse(e);
} catch (Throwable throwable) {
Expand Down
11 changes: 11 additions & 0 deletions transport/rest/src/test/java/io/a2a/transport/rest/handler/RestHandlerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,17 @@ public void testGetTaskNotFound() {
Assertions.assertTrue(response.getBody().contains("TaskNotFoundError"));
}

@Test
public void testGetTaskNegativeHistoryLengthReturns422() {
RestHandler handler = new RestHandler(CARD, requestHandler, internalExecutor);

RestHandler.HTTPRestResponse response = handler.getTask(callContext, "", MINIMAL_TASK.id(), -1);

Assertions.assertEquals(422, response.getStatusCode());
Assertions.assertEquals("application/json", response.getContentType());
Assertions.assertTrue(response.getBody().contains("InvalidParamsError"));
}

@Test
public void testListTasksStatusWireString() {
RestHandler handler = new RestHandler(CARD, requestHandler, internalExecutor);
Expand Down
Loading