-
Notifications
You must be signed in to change notification settings - Fork 205
test(webview): add Playwright visual regression harness #526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
edelauna
wants to merge
9
commits into
main
Choose a base branch
from
issue/515
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b48e2b8
test(webview): add visual regression harness
edelauna 8904d28
fix(webview): resolve relative compose path & font race in visual tests
edelauna 6c57761
test(webview): configure Codecov JSDOM coverage ratcheting
edelauna 12a29dd
feat(webview): add Playwright CT coverage ratcheting
edelauna ac73e6e
fix(webview): swap visual regression target off deprecated toolkit
edelauna 342e2b6
chore(webview): address CodeRabbit review feedback
edelauna 6b64b11
fix(webview): emit Playwright CT coverage LCOV
edelauna 4401e58
fix(webview): address code review feedback for Playwright CT harness
edelauna 0382bd5
docs: prefer committed visual snapshots; split videos into their own …
edelauna File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| name: Webview Visual Regression | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| pull_request: | ||
| types: [opened, reopened, ready_for_review, synchronize] | ||
| paths: | ||
| - "webview-ui/**" | ||
| - "src/shared/**" | ||
| - "package.json" | ||
| - "pnpm-lock.yaml" | ||
| - ".github/workflows/visual-regression.yml" | ||
| merge_group: | ||
| types: [checks_requested] | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| webview-visual: | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 10 | ||
| container: | ||
| image: mcr.microsoft.com/playwright:v1.60.0-noble@sha256:9bd26ad900bb5e0f4dee75839e957a89ae89c2b7ab1e76050e559790e946b948 | ||
| options: --ipc=host | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4 | ||
| with: | ||
| persist-credentials: false | ||
| - name: Setup Node.js and pnpm | ||
| uses: ./.github/actions/setup-node-pnpm | ||
| with: | ||
| install-args: "--frozen-lockfile" | ||
| - name: Run webview visual tests | ||
| run: pnpm --filter @roo-code/vscode-webview test:visual | ||
| - name: Upload visual test coverage to Codecov | ||
| if: always() | ||
| uses: codecov/codecov-action@b9fd7d16f6d7d1b5d2bec1a2887e65ceed900238 # v4 | ||
| with: | ||
| files: webview-ui/coverage-ct/lcov.info | ||
| disable_search: true | ||
| flags: webview-ui-ct | ||
| token: ${{ secrets.CODECOV_TOKEN }} | ||
| - name: Upload visual test artifacts | ||
| if: failure() | ||
| uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4 | ||
| with: | ||
| name: webview-visual-regression | ||
| path: | | ||
| webview-ui/playwright-report | ||
| webview-ui/test-results | ||
| if-no-files-found: ignore | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.