UN-3447 [MISC] Expand workers coverage and isort scope to all 11 packages by muhammad-ali-e · Pull Request #1940 · Zipstack/unstract

muhammad-ali-e · 2026-05-05T10:30:43Z

What

Expand pytest coverage configuration in workers/pyproject.toml to measure all 11 worker packages.
Add the same 6 packages to [tool.isort].known_first_party so isort treats their imports as first-party (per Greptile review).
Previous coverage config only measured 5 of 11: shared, api_deployment, general, file_processing, callback.
Added: executor, pluggable_worker, notification, scheduler, log_consumer, ide_callback.

Why

First task in the upcoming workers/ rollout work (UN-3445, UN-3446).
The executor/ worker and pluggable_worker/ slot were both excluded from coverage measurement — a blind spot directly on the workers central to the rollout.
Same packages were also missing from isort's first-party list — without this, isort would mis-group their imports on format runs.
Establishing an accurate baseline informs which seams need characterisation tests in upcoming PRs.

How

Added 6 --cov= flags to [tool.pytest.ini_options].addopts.
Added the same 6 entries to [tool.coverage.run].source.
Added the same 6 entries to [tool.isort].known_first_party.
Single-file diff, ~19 lines added across three sections.

Can this PR break any existing features. If yes, please list possible items. If no, please explain why.

No. Coverage and isort configuration changes only affect test reporting and import-sort behaviour respectively — neither changes runtime behaviour. 544 of 547 tests pass; the 3 pre-existing test failures are unrelated to this change and tracked separately on UN-3446.

Database Migrations

None.

Env Config

None.

Related Issues or PRs

UN-3445
UN-3446
UN-3447

Dependencies Versions

None changed.

Notes on Testing

Refresh the coverage baseline anytime locally:

cd workers
PYTHONPATH=.:../unstract .venv/bin/pytest --tb=no -q

Reports are written to htmlcov/, coverage.xml, .coverage (all gitignored).

Baseline at this PR: 34% total (17,458 stmts, 11,534 missed). 0% coverage on callback (607 stmts), notification (397), log_consumer (128) — these are the very files upcoming PRs will touch and become explicit input to the next characterisation suite.

Screenshots

N/A — config-only change.

Checklist

🤖 Generated with Claude Code

Coverage configuration in workers/pyproject.toml previously measured only 5 of 11 worker packages (shared, api_deployment, general, file_processing, callback). This left ~2,843 statements unmeasured, including the executor worker (labs E1 C-prep) and the pluggable_worker slot — both central to the upcoming PG Queue migration (Epic UN-3445). Added executor, pluggable_worker, notification, scheduler, log_consumer, and ide_callback to both pytest --cov= flags and [tool.coverage.run].source. Non-regressive: only adds measurement scope. First task under Story UN-3446 (Phase 1 — Test Infrastructure). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

coderabbitai · 2026-05-05T10:30:59Z

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)

uv.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cec74421-3a3e-467e-99ff-244ccff41be3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Walkthrough

The workers/pyproject.toml configuration was updated to expand coverage collection and import-sorting awareness to additional packages: executor, pluggable_worker, notification, scheduler, log_consumer, and ide_callback.

Changes

Coverage & Import Sorting Expansion

Layer / File(s)	Summary
Import-sorting first-party list `workers/pyproject.toml`	`[tool.isort].known_first_party` extended to include `executor`, `pluggable_worker`, `notification`, `scheduler`, `log_consumer`, and `ide_callback` alongside `callback`.
Pytest coverage flags `workers/pyproject.toml`	`[tool.pytest.ini_options].addopts` updated to add `--cov=executor`, `--cov=pluggable_worker`, `--cov=notification`, `--cov=scheduler`, `--cov=log_consumer`, and `--cov=ide_callback`.
Coverage source list `workers/pyproject.toml`	`[tool.coverage.run].source` expanded to include `callback`, `executor`, `pluggable_worker`, `notification`, `scheduler`, `log_consumer`, and `ide_callback`.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically summarizes the main change: expanding coverage configuration and isort scope to all 11 worker packages.
Description check	✅ Passed	The description comprehensively covers all required sections with detailed explanations of what changed, why it matters, and how it was implemented.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch misc/UN-3447-MISC_expand_workers_coverage_scope

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

Generate code and open pull requests
Plan features and break down work
Investigate incidents and troubleshoot customer tickets together
Automate recurring tasks and respond to alerts with triggers
Summarize progress and report instantly

Built for teams:

Shared memory across your entire org—no repeating context
Per-thread sandboxes to safely plan and execute work
Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

greptile-apps · 2026-05-05T10:32:19Z

Greptile Summary

This PR expands workers/pyproject.toml to include 6 previously missing worker packages (executor, pluggable_worker, notification, scheduler, log_consumer, ide_callback) in pytest coverage flags, [tool.coverage.run].source, and [tool.isort].known_first_party. However, the PR also inadvertently includes a large uv.lock regeneration with ~30+ package version bumps that are unrelated to the config change.

workers/pyproject.toml: Correctly mirrors the 6 new packages across all three relevant config sections, closing the coverage blind spot on the workers central to the upcoming rollout (UN-3445/UN-3446).
uv.lock: Contains unrelated runtime dependency upgrades (e.g., aiohttp 3.12.15 → 3.13.5, anyio 4.11.0 → 4.13.0, asyncpg 0.30.0 → 0.31.0) that were not mentioned in the PR description and should be reviewed and merged separately."

Confidence Score: 4/5

The pyproject.toml change is safe and correct, but the lockfile bundles ~30 unintended package version bumps that could introduce regressions in production.

The workers/pyproject.toml edits are straightforward and non-breaking. The concern is entirely in uv.lock: a large set of dependency upgrades (aiohttp, anyio, boto3/botocore, asyncpg, cryptography, certifi, and more) appear to have been pulled in by a uv lock or uv sync run during development and committed alongside the config change. These are real runtime dependency updates that can affect behaviour across the platform.

The uv.lock file requires attention — it contains numerous unintended package version upgrades that should be split into a separate PR.

Important Files Changed

Filename	Overview
workers/pyproject.toml	Correctly adds 6 missing worker packages to --cov flags, [tool.coverage.run].source, and [tool.isort].known_first_party; addresses the prior Greptile comment about missing isort entries.
uv.lock	Contains ~30+ unintended package version bumps (aiohttp, anyio, boto3/botocore, asyncpg, cryptography, certifi, etc.) not mentioned in the PR description; these runtime changes should be in a dedicated PR.

Comments Outside Diff (1)

uv.lock, line 1 (link)

Unintended dependency upgrades included in lockfile

The PR description states this is a "single-file diff" and that "neither changes runtime behaviour," but uv.lock contains ~30+ package version bumps entirely unrelated to the coverage/isort config changes in workers/pyproject.toml. Notable upgrades include aiohttp 3.12.15 → 3.13.5, anyio 4.11.0 → 4.13.0, boto3/botocore 1.34.131 → 1.34.162, certifi 2025.8.3 → 2026.4.22, and asyncpg 0.30.0 → 0.31.0. These are real runtime dependency changes that may introduce regressions across the whole platform and should not be bundled into a config-only PR without explicit review and CI sign-off.

Prompt To Fix With AI

This is a comment left during a code review.
Path: uv.lock
Line: 1

Comment:
**Unintended dependency upgrades included in lockfile**

The PR description states this is a "single-file diff" and that "neither changes runtime behaviour," but `uv.lock` contains ~30+ package version bumps entirely unrelated to the coverage/isort config changes in `workers/pyproject.toml`. Notable upgrades include `aiohttp` 3.12.15 → 3.13.5, `anyio` 4.11.0 → 4.13.0, `boto3`/`botocore` 1.34.131 → 1.34.162, `certifi` 2025.8.3 → 2026.4.22, and `asyncpg` 0.30.0 → 0.31.0. These are real runtime dependency changes that may introduce regressions across the whole platform and should not be bundled into a config-only PR without explicit review and CI sign-off.

How can I resolve this? If you propose a fix, please make it concise.

Prompt To Fix All With AI

Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
uv.lock:1
**Unintended dependency upgrades included in lockfile**

The PR description states this is a "single-file diff" and that "neither changes runtime behaviour," but `uv.lock` contains ~30+ package version bumps entirely unrelated to the coverage/isort config changes in `workers/pyproject.toml`. Notable upgrades include `aiohttp` 3.12.15 → 3.13.5, `anyio` 4.11.0 → 4.13.0, `boto3`/`botocore` 1.34.131 → 1.34.162, `certifi` 2025.8.3 → 2026.4.22, and `asyncpg` 0.30.0 → 0.31.0. These are real runtime dependency changes that may introduce regressions across the whole platform and should not be bundled into a config-only PR without explicit review and CI sign-off.

_{Reviews (5): Last reviewed commit: "UN-3449 [FIX] Refresh root `uv.lock` — f..." | Re-trigger Greptile}

Greptile flagged the same 6 packages we added to coverage scope are also missing from [tool.isort].known_first_party. Without this, isort won't treat imports from executor/, pluggable_worker/, notification/, scheduler/, log_consumer/, and ide_callback/ as first-party — they'd get mis-grouped on format runs against those packages' files. Same fix, same file — keeping config consistent. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…1945) UN-3449 [FIX] Refresh root uv.lock — fix malformed banks entry The root uv.lock had a malformed banks entry that prevented uv from parsing it: error: Failed to parse `uv.lock` Caused by: The entry for package `banks` v2.4.1 has wheel `banks-2.2.0-py3-none-any.whl` with inconsistent version: v2.2.0 The version field claimed v2.4.1 but the sdist/wheel filenames were both v2.2.0. The PyPI upload-time on the wheel matches banks 2.2.0's release date, so the artifacts really are 2.2.0 — most likely a manual edit or a partial-write bug in an older uv version. banks is a transitive dependency pulled in by llama-index-core v0.14.16 (LlamaIndex's prompt-templating library). Unstract code does not import banks directly. Fix: regenerate via `rm uv.lock && uv lock`. After regen, banks resolves to v2.4.2 with consistent artifacts. Why 1,557 lines change: the auto-update workflow has been broken since 2026-04-01 (now fixed in UN-3448 / PR #1941), so the root lock has been 5 weeks stale. `uv lock` re-resolves everything against current PyPI, picking up minor/patch bumps the workflow would have applied over those 5 weeks. So the diff is: - banks 2.4.1 → 2.4.2 (the actual fix) - ~271 other packages with incidental drift (what the workflow would have done anyway) Surgical hand-editing was considered and rejected — fragile, and a future pyproject.toml-touching PR would trigger this same refresh once the workflow runs again. Verified: `uv lock --check` exits 0 (Resolved 272 packages in 3ms). Unblocks the `Update UV lock in all directories` check on PR #1940 and any future PRs that touch a pyproject.toml. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

sonarqubecloud · 2026-05-06T07:28:07Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2026-05-06T07:28:42Z

Test Results

Summary

✅ Runner Tests: 11 passed, 0 failed (11 total)
✅ SDK1 Tests: 230 passed, 0 failed (230 total)

Runner Tests - Full Report

filepath	function	$$\textcolor{#23d18b}{\tt{passed}}$$	SUBTOTAL
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$	$$\textcolor{#23d18b}{\tt{test\_logs}}$$	$$\textcolor{#23d18b}{\tt{1}}$$	$$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$	$$\textcolor{#23d18b}{\tt{test\_cleanup}}$$	$$\textcolor{#23d18b}{\tt{1}}$$	$$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$	$$\textcolor{#23d18b}{\tt{test\_cleanup\_skip}}$$	$$\textcolor{#23d18b}{\tt{1}}$$	$$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$	$$\textcolor{#23d18b}{\tt{test\_client\_init}}$$	$$\textcolor{#23d18b}{\tt{1}}$$	$$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$	$$\textcolor{#23d18b}{\tt{test\_get\_image\_exists}}$$	$$\textcolor{#23d18b}{\tt{1}}$$	$$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$	$$\textcolor{#23d18b}{\tt{test\_get\_image}}$$	$$\textcolor{#23d18b}{\tt{1}}$$	$$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$	$$\textcolor{#23d18b}{\tt{test\_get\_container\_run\_config}}$$	$$\textcolor{#23d18b}{\tt{1}}$$	$$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$	$$\textcolor{#23d18b}{\tt{test\_get\_container\_run\_config\_without\_mount}}$$	$$\textcolor{#23d18b}{\tt{1}}$$	$$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$	$$\textcolor{#23d18b}{\tt{test\_run\_container}}$$	$$\textcolor{#23d18b}{\tt{1}}$$	$$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$	$$\textcolor{#23d18b}{\tt{test\_get\_image\_for\_sidecar}}$$	$$\textcolor{#23d18b}{\tt{1}}$$	$$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$	$$\textcolor{#23d18b}{\tt{test\_sidecar\_container}}$$	$$\textcolor{#23d18b}{\tt{1}}$$	$$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{TOTAL}}$$		$$\textcolor{#23d18b}{\tt{11}}$$	$$\textcolor{#23d18b}{\tt{11}}$$

SDK1 Tests - Full Report

muhammad-ali-e changed the title ~~UN-3447 [MISC] Expand workers coverage scope to all 11 packages~~ UN-3447 [MISC] Expand workers coverage and isort scope to all 11 packages May 5, 2026

Merge branch 'main' into misc/UN-3447-MISC_expand_workers_coverage_scope

49ac7f8

muhammad-ali-e requested review from athul-rs, harini-venkataraman, jaseemjaskp, johnyrahul, pk-zipstack and ritwik-g May 5, 2026 11:12

johnyrahul approved these changes May 5, 2026

View reviewed changes

jaseemjaskp approved these changes May 5, 2026

View reviewed changes

harini-venkataraman approved these changes May 5, 2026

View reviewed changes

Merge branch 'main' into misc/UN-3447-MISC_expand_workers_coverage_scope

af8c389

muhammad-ali-e mentioned this pull request May 6, 2026

UN-3449 [FIX] Refresh root uv.lock — fix malformed banks entry #1945

Merged

11 tasks

athul-rs approved these changes May 6, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UN-3447 [MISC] Expand workers coverage and isort scope to all 11 packages#1940

UN-3447 [MISC] Expand workers coverage and isort scope to all 11 packages#1940
muhammad-ali-e wants to merge 5 commits intomainfrom
misc/UN-3447-MISC_expand_workers_coverage_scope

muhammad-ali-e commented May 5, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented May 5, 2026 •

edited

Loading

Review skipped

Uh oh!

greptile-apps Bot commented May 5, 2026 •

edited

Loading

Greptile Summary

Confidence Score: 4/5

Important Files Changed

Comments Outside Diff (1)

Uh oh!

sonarqubecloud Bot commented May 6, 2026

Uh oh!

github-actions Bot commented May 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

muhammad-ali-e commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Why

How

Can this PR break any existing features. If yes, please list possible items. If no, please explain why.

Database Migrations

Env Config

Related Issues or PRs

Dependencies Versions

Notes on Testing

Screenshots

Checklist

Uh oh!

coderabbitai Bot commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Estimated code review effort

Uh oh!

greptile-apps Bot commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 4/5

Important Files Changed

Comments Outside Diff (1)

Uh oh!

sonarqubecloud Bot commented May 6, 2026

Quality Gate passed

Uh oh!

github-actions Bot commented May 6, 2026

Test Results

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

muhammad-ali-e commented May 5, 2026 •

edited

Loading

coderabbitai Bot commented May 5, 2026 •

edited

Loading

greptile-apps Bot commented May 5, 2026 •

edited

Loading